Skip to contentSkip to conversation

pcnet32: added pci_disable_device

PATCH New Don Fry 1 participant 1 message Nov 12, 2004

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Don Fry

author
#0 lore raw

PATCH 1/1 pcnet32: added pci_disable_device

This patch adds pci_disable_device in the appropriate places to eliminate the following message when removing the module.

pcnet32 0000:00:05.0: Device was removed without properly calling pci_disable_device(). This may need fixing. pcnet32 0000:02:05.0: Device was removed without properly calling pci_disable_device(). This may need fixing.

Tested ia32.

Signed-off-by Don Fry <[email protected]>
drivers/net/pcnet32.c renamed from drivers/net/pcnet32.c.orig +6 -1
@@ -1010,7 +1010,11 @@ pcnet32_probe_pci(struct pci_dev *pdev, 
 	return -EBUSY;
     }
 
-    return pcnet32_probe1(ioaddr, 1, pdev);
+    err =  pcnet32_probe1(ioaddr, 1, pdev);
+    if (err < 0) {
+	pci_disable_device(pdev);
+    }
+    return err;
 }
 
 

@@ -2249,6 +2253,7 @@ static void __devexit pcnet32_remove_one
 	release_region(dev->base_addr, PCNET32_TOTAL_SIZE);
 	pci_free_consistent(lp->pci_dev, sizeof(*lp), lp, lp->dma_addr);
 	free_netdev(dev);
+	pci_disable_device(pdev);
 	pci_set_drvdata(pdev, NULL);
     }
 }
Signature · 2 lines
Don Fry
[email protected]