Skip to contentSkip to conversation

I2C: Missing newlines in debug messages

PATCH New Jean Delvare 2 participants 2 messages May 19, 2005 I2C

lore
Share & tools
lore

Jean Delvare

author
#0 lore raw

PATCH 1/1 I2C: Missing newlines in debug messages

Hi Greg,

As discussed on IRC, this simple patch fixes broken debug messages missing their trailing newlines. I just applied something similar to CVS, and will prepare patches for 2.4 as well.

Please apply,
thanks.

Signed-off-by Jean Delvare <[email protected]>
drivers/i2c/i2c-core.c renamed from drivers/i2c.orig/i2c-core.c +1 -1
diff -ruN linux-2.6.10-rc1-bk19/drivers/i2c.orig/i2c-core.c linux-2.6.10-rc1-bk19/drivers/i2c/i2c-core.c
@@ -760,7 +760,7 @@
 			if (addr = address_data->normal_i2c[i]) {
 				found = 1;
 				dev_dbg(&adapter->dev, "found normal i2c entry for adapter %d, "
-					"addr %02x", adap_id,addr);
+					"addr %02x\n", adap_id, addr);
 			}
 		}
drivers/i2c/i2c-dev.c renamed from drivers/i2c.orig/i2c-dev.c +1 -1
diff -ruN linux-2.6.10-rc1-bk19/drivers/i2c.orig/i2c-dev.c linux-2.6.10-rc1-bk19/drivers/i2c/i2c-dev.c
@@ -539,7 +539,7 @@
 out_unreg_chrdev:
 	unregister_chrdev(I2C_MAJOR, "i2c");
 out:
-	printk(KERN_ERR "%s: Driver Initialisation failed", __FILE__);
+	printk(KERN_ERR "%s: Driver Initialisation failed\n", __FILE__);
 	return res;
 }
drivers/i2c/i2c-sensor-detect.c renamed from drivers/i2c.orig/i2c-sensor-detect.c +1 -1
diff -ruN linux-2.6.10-rc1-bk19/drivers/i2c.orig/i2c-sensor-detect.c linux-2.6.10-rc1-bk19/drivers/i2c/i2c-sensor-detect.c
@@ -115,7 +115,7 @@
 			for (i = 0; !found && (normal_i2c[i] != I2C_CLIENT_END); i += 1) {
 				if (addr = normal_i2c[i]) {
 					found = 1;
-					dev_dbg(&adapter->dev, "found normal i2c entry for adapter %d, addr %02x", adapter_id, addr);
+					dev_dbg(&adapter->dev, "found normal i2c entry for adapter %d, addr %02x\n", adapter_id, addr);
 				}
 			}
 		}
Signature · 2 lines
Jean Delvare
http://khali.linux-fr.org/
Applied
#1 lore raw

PATCH 1/1 I2C: Missing newlines in debug messages

Quoted 5 lines · Jean Delvare

Hi Greg,

As discussed on IRC, this simple patch fixes broken debug messages missing their trailing newlines. I just applied something similar to CVS, and will prepare patches for 2.4 as well.

Applied, thanks.

greg k-h