Skip to contentSkip to conversation

include ordering breaks sysrq on 8250 serial

PATCH In review Matt Mackall 2 participants 2 messages Nov 12, 2004

lore
Share & tools
lore

Matt Mackall

author
#0 lore raw

PATCH 1/1 include ordering breaks sysrq on 8250 serial

This has been pestering me for a couple days, finally dug into it:

serial_8250.h was including serial_core.h before SUPPORT_SYSRQ was getting set up. I suspect this problem exists elsewhere. Tested against latest bk snapshot.

Signed-off-by Matt Mackall <[email protected]>
drivers/serial/8250.c +5 -4
Index: l-bk20/drivers/serial/8250.c
===================================================================
@@ -20,6 +20,11 @@
  *  membase is an 'ioremapped' cookie.
  */
 #include <linux/config.h>
+
+#if defined(CONFIG_SERIAL_8250_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
+#define SUPPORT_SYSRQ
+#endif
+
 #include <linux/module.h>
 #include <linux/moduleparam.h>
 #include <linux/tty.h>

@@ -37,10 +42,6 @@
 #include <asm/io.h>
 #include <asm/irq.h>
 
-#if defined(CONFIG_SERIAL_8250_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
-#define SUPPORT_SYSRQ
-#endif
-
 #include <linux/serial_core.h>
 #include "8250.h"
Signature · 1 line
Mathematics is the supreme nostalgia of our time.
#1 lore raw
Quoted 5 lines · Matt Mackall

This has been pestering me for a couple days, finally dug into it:

serial_8250.h was including serial_core.h before SUPPORT_SYSRQ was getting set up. I suspect this problem exists elsewhere. Tested against latest bk snapshot.

Thanks! I tried using it and thought perhaps i had finally conceded to the little men in my head!