Skip to contentSkip to conversation

net/core/pktgen.c shouldn't include pci.h

PATCH In review Adrian Bunk 2 participants 2 messages Nov 13, 2004 – Nov 14, 2004

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 net/core/pktgen.c shouldn't include pci.h

If rebuilding after touching pci.h in 2.6, net/core/pktgen.c is the only file under net/ that gets rebuilt.

I searched and didn't find any reason why net/core/pktgen.c needs to include pci.h .

I'm therefore suggesting the patch below (applies against both 2.4 and 2.6).

Signed-off-by Adrian Bunk <[email protected]>
net/core/pktgen.c renamed from net/core/pktgen.c.old +0 -1
@@ -69,7 +69,6 @@
 #include <linux/ioport.h>
 #include <linux/slab.h>
 #include <linux/interrupt.h>
-#include <linux/pci.h>
 #include <linux/delay.h>
 #include <linux/init.h>
 #include <linux/inet.h>
maintainer
#1 lore raw
Quoted 8 lines · On Sat, 13 Nov 2004 15:53:51 +0100 Adrian Bunk <[email protected]> wrote:

If rebuilding after touching pci.h in 2.6, net/core/pktgen.c is the only file under net/ that gets rebuilt.

I searched and didn't find any reason why net/core/pktgen.c needs to include pci.h .

I'm therefore suggesting the patch below (applies against both 2.4 and 2.6).

Yeah, that's pretty weird. Patch applied, thanks Adrian :)