Skip to contentSkip to conversation

Parenthize nth_page() macro arg, in linux/mm.h.

DISCUSSION William Lee Irwin III 2 participants 3 messages Nov 14, 2004 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

include/linux/mm.h line 43

Quoted 12 lines · Linux Kernel Mailing List

ChangeSet 1.2092.7.2, 2004/11/13 14:43:08-05:00, [email protected]
Parenthize nth_page() macro arg, in linux/mm.h.

 mm.h |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -Nru a/include/linux/mm.h b/include/linux/mm.h

include/linux/mm.h +1 -1
@@ -41,7 +41,7 @@
 #define MM_VM_SIZE(mm)	TASK_SIZE
 #endif
-#define nth_page(page,n) pfn_to_page(page_to_pfn((page)) + n)
+#define nth_page(page,n) pfn_to_page(page_to_pfn((page)) + (n))

Okay, #1 the ((page)) thing should be unnecessary. If it is necessary, arch code is broken, which leads to #2: this came about because alpha wasn't parenthesizing its args in pfn_to_page(); where did the fix for that go?

-- wli

#2 lore raw
Quoted 10 lines · William Lee Irwin III
Quoted 9 lines · Linux Kernel Mailing List

ChangeSet 1.2092.7.2, 2004/11/13 14:43:08-05:00, [email protected]
Parenthize nth_page() macro arg, in linux/mm.h.

 mm.h |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -Nru a/include/linux/mm.h b/include/linux/mm.h

include/linux/mm.h +0 -0
@@ -41,7 +41,7 @@
 #define MM_VM_SIZE(mm)	TASK_SIZE
Quoted 8 lines

include/linux/mm.h line 43

Quoted 3 lines
include/linux/mm.h +1 -1
 #endif
-#define nth_page(page,n) pfn_to_page(page_to_pfn((page)) + n)
+#define nth_page(page,n) pfn_to_page(page_to_pfn((page)) + (n))

Okay, #1 the ((page)) thing should be unnecessary. If it is necessary, arch code is broken, which leads to #2: this came about because alpha wasn't parenthesizing its args in pfn_to_page(); where did the fix for that go?

In my tree; I'm preparing -bk23-bird1 right now, will post in an hour or so.

#3 lore raw
Quoted 4 lines · William Lee Irwin III
Quoted 4 lines

Okay, #1 the ((page)) thing should be unnecessary. If it is necessary, arch code is broken, which leads to #2: this came about because alpha wasn't parenthesizing its args in pfn_to_page(); where did the fix for that go?

Quoted 1 line · Al Viro

In my tree; I'm preparing -bk23-bird1 right now, will post in an hour or so.

Sounds good to me. Thanks for clearing up my misunderstanding.

-- wli