Skip to contentSkip to conversation

use local_softirq_pending instead of softirq_pending in netif_rx_ni

PATCH Applied Christoph Hellwig 2 participants 2 messages Nov 14, 2004 – Nov 18, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 use local_softirq_pending instead of softirq_pending in netif_rx_ni

Some architectures can optimize local_softirq_pending much better than softirq_pending(smp_processor_id()), and for all others the former is just a macro expanding to the later.

Also this is the last use of softirq_pending() in common code, once this is in we can soon kill the notation of beeing able to query other cpus softirq pending count.

net/core/dev.c +1 -1
@@ -1470,7 +1470,7 @@ int netif_rx_ni(struct sk_buff *skb)
 
 	preempt_disable();
 	err = netif_rx(skb);
-	if (softirq_pending(smp_processor_id()))
+	if (local_softirq_pending())
 		do_softirq();
 	preempt_enable();
 
maintainer Applied
#1 lore raw
Quoted 7 lines · On Sun, 14 Nov 2004 11:38:46 +0100 Christoph Hellwig <[email protected]> wrote:

Some architectures can optimize local_softirq_pending much better than softirq_pending(smp_processor_id()), and for all others the former is just a macro expanding to the later.

Also this is the last use of softirq_pending() in common code, once this is in we can soon kill the notation of beeing able to query other cpus softirq pending count.

Queued for 2.6.11, thanks Christoph.