kill unused call_irq()
PATCH 1/1 kill unused call_irq()
These routine in arm and arm26 is unused (in fact not even compiled).
Inatead of converting it to local_softirq_pending I'd suggest just removing it as below as it's been there totally unused for a long time.
Inatead of converting it to local_softirq_pending I'd suggest just removing it as below as it's been there totally unused for a long time.
include/asm-arm/mach/irq.h +0 -17
@@ -97,23 +97,6 @@ void __set_irq_handler(unsigned int irq,void set_irq_chip (unsigned int irq,struct irqchip *);void set_irq_flags (unsigned int irq,unsigned int flags); -#ifdef not_yet -/* -* This is to be used by the top-level machine IRQ decoder only. -*/ -static inline void call_irq (struct pt_regs *regs,unsigned int irq) -{ -struct irqdesc *desc = irq_desc + irq; - -spin_lock (&irq_controller_lock); - desc->handle (irq, desc, regs); -spin_unlock (&irq_controller_lock); - -if (softirq_pending (smp_processor_id ())) -do_softirq (); -} -#endif -#define IRQF_VALID (1 << 0)#define IRQF_PROBE (1 << 1)#define IRQF_NOAUTOEN (1 << 2)
include/asm-arm26/irqchip.h +0 -17
@@ -85,23 +85,6 @@ void __set_irq_handler(unsigned int irq,void set_irq_chip (unsigned int irq,struct irqchip *);void set_irq_flags (unsigned int irq,unsigned int flags); -#ifdef not_yet -/* -* This is to be used by the top-level machine IRQ decoder only. -*/ -static inline void call_irq (struct pt_regs *regs,unsigned int irq) -{ -struct irqdesc *desc = irq_desc + irq; - -spin_lock (&irq_controller_lock); - desc->handle (irq, desc, regs); -spin_unlock (&irq_controller_lock); - -if (softirq_pending (smp_processor_id ())) -do_softirq (); -} -#endif -#define IRQF_VALID (1 << 0)#define IRQF_PROBE (1 << 1)#define IRQF_NOAUTOEN (1 << 2)
Russell King
AppliedQuoted 4 lines · Christoph Hellwig
These routine in arm and arm26 is unused (in fact not even compiled).
Inatead of converting it to
local_softirq_pendingI'd suggest just removing it as below as it's been there totally unused for a long time.
I've applied the ARM bit... Ian - please handle ARM26 bit below. Thanks.
include/asm-arm26/irqchip.h +0 -17
@@ -85,23 +85,6 @@ void __set_irq_handler(unsigned int irq,void set_irq_chip (unsigned int irq,struct irqchip *);void set_irq_flags (unsigned int irq,unsigned int flags); -#ifdef not_yet -/* -* This is to be used by the top-level machine IRQ decoder only. -*/ -static inline void call_irq (struct pt_regs *regs,unsigned int irq) -{ -struct irqdesc *desc = irq_desc + irq; - -spin_lock (&irq_controller_lock); - desc->handle (irq, desc, regs); -spin_unlock (&irq_controller_lock); - -if (softirq_pending (smp_processor_id ())) -do_softirq (); -} -#endif -#define IRQF_VALID (1 << 0)#define IRQF_PROBE (1 << 1)#define IRQF_NOAUTOEN (1 << 2)
Signature · 4 lines
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial coreIan Molton
AppliedQuoted 9 lines · Russell King
Quoted 4 lines · Christoph Hellwig
These routine in arm and arm26 is unused (in fact not even compiled).
Inatead of converting it to
local_softirq_pendingI'd suggest just removing it as below as it's been there totally unused for a long time.I've applied the ARM bit... Ian - please handle ARM26 bit below. Thanks.
Applied. thanks.
(wow, arm26 is a mes right now - only 3 minor versions and it needed a ton of fixes. I gotta push some of my patch(es) mainline-ward...)