Skip to contentSkip to conversation

OSS via82cxxx_audio.c: enable procfs code

PATCH In review Adrian Bunk 3 participants 5 messages Nov 14, 2004 – Nov 15, 2004 Sound

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 OSS via82cxxx_audio.c: enable procfs code

The patch below enables the procfs code in sound/oss/via82cxxx_audio.c if CONFIG_PROC_FS=y.

This fuxes Bugzilla #3738.

diffstat output:

 sound/oss/via82cxxx_audio.c |   11 +++--------
 1 files changed, 3 insertions(+), 8 deletions(-)
Signed-off-by Adrian Bunk <[email protected]>
sound/oss/via82cxxx_audio.c renamed from sound/oss/via82cxxx_audio.c.old +3 -8
@@ -62,11 +62,6 @@
         }
 #endif
 
-#if defined(CONFIG_PROC_FS) && \
-    defined(CONFIG_SOUND_VIA82CXXX_PROCFS)
-#define VIA_PROC_FS 1
-#endif
-
 #define VIA_SUPPORT_MMAP 1 /* buggy, for now... */
 
 #define MAX_CARDS	1

@@ -366,7 +361,7 @@
 static void via_chan_pcm_fmt (struct via_channel *chan, int reset);
 static void via_chan_buffer_free (struct via_info *card, struct via_channel *chan);
 
-#ifdef VIA_PROC_FS
+#ifdef CONFIG_PROC_FS
 static int via_init_proc (void);
 static void via_cleanup_proc (void);
 static int via_card_init_proc (struct via_info *card);

@@ -3652,7 +3647,7 @@
 MODULE_LICENSE("GPL");
 
 
-#ifdef VIA_PROC_FS
+#ifdef CONFIG_PROC_FS
 
 /****************************************************************
  *

@@ -3828,4 +3823,4 @@
 	DPRINTK ("EXIT\n");
 }
 
-#endif /* VIA_PROC_FS */
+#endif /* CONFIG_PROC_FS */
#1 lore raw
Quoted 2 lines · Adrian Bunk

The patch below enables the procfs code in sound/oss/via82cxxx_audio.c if CONFIG_PROC_FS=y.

I don't see what needs fixing here. Generally the /proc file shouldnt exist

#2 lore raw
Quoted 7 lines · Alan Cox
Quoted 1 line · Adrian Bunk

The patch below enables the procfs code in sound/oss/via82cxxx_audio.c if CONFIG_PROC_FS=y.

I don't see what needs fixing here. Generally the /proc file shouldnt exist

Existing procfs code in via82cxxx_audio is never enabled, due to removal of CONFIG_SOUND_VIA82CXXX_PROCFS:

#if defined(CONFIG_PROC_FS) && \
defined(CONFIG_SOUND_VIA82CXXX_PROCFS)
#define VIA_PROC_FS 1
#endif

However, I don't mind if someone removes the procfs code completely.

Jeff

author
#3 lore raw
Quoted 13 lines · Jeff Garzik
Quoted 8 lines · Alan Cox
Quoted 2 lines · Adrian Bunk

The patch below enables the procfs code in sound/oss/via82cxxx_audio.c if CONFIG_PROC_FS=y.

I don't see what needs fixing here. Generally the /proc file shouldnt exist

Existing procfs code in via82cxxx_audio is never enabled, due to removal of CONFIG_SOUND_VIA82CXXX_PROCFS:

Quoted 6 lines

#if defined(CONFIG_PROC_FS) && \
defined(CONFIG_SOUND_VIA82CXXX_PROCFS)
#define VIA_PROC_FS 1
#endif

However, I don't mind if someone removes the procfs code completely.

How else is this information available?

Quoted 1 line

Jeff

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#4 lore raw
Quoted 20 lines · Adrian Bunk
Quoted 18 lines · Jeff Garzik
Quoted 8 lines · Alan Cox
Quoted 1 line · Adrian Bunk

The patch below enables the procfs code in sound/oss/via82cxxx_audio.c if CONFIG_PROC_FS=y.

I don't see what needs fixing here. Generally the /proc file shouldnt exist

Existing procfs code in via82cxxx_audio is never enabled, due to removal of CONFIG_SOUND_VIA82CXXX_PROCFS:

#if defined(CONFIG_PROC_FS) && \
defined(CONFIG_SOUND_VIA82CXXX_PROCFS)
#define VIA_PROC_FS 1
#endif

Quoted 4 lines
Quoted 1 line

However, I don't mind if someone removes the procfs code completely.

How else is this information available?

lspci. it's just a verbose dump of PCI config registers.