2.6.10-rc2 dm.c dm_init unresolved reference to _exits
ia64 build, gcc version 3.2.3 20030502 (Red Hat Linux 3.2.3-24)
CONFIG_BLK_DEV_DM=yCONFIG_HOTPLUG=n
drivers/md/dm.c dm_int refers to _exits which is defined as __exitdata. With CONFIG_HOTPLUG=n, __exitdata is discarded by arch/ia64/kernel/vmlinux.lds.S.
drivers/built-in.o(.init.text+0x1f720): In function `dm_init':
: undefined reference to _exits' drivers/built-in.o(.init.text+0x1f730): In function dm_init':
: undefined reference to `_exits'
Quoted 4 lines · Keith Owens
ia64 build, gcc version 3.2.3 20030502 (Red Hat Linux 3.2.3-24)
drivers/md/dm.cdm_intrefers to_exitswhich is defined as__exitdata. WithCONFIG_HOTPLUG=n,__exitdatais discarded
Yes - thanks for reminding - thought of that yesterday night but forgot again the next morning.
drivers/md/dm.c +1 -1
@@ -146,7 +146,7 @@ int (*_inits[])(void) __initdata = { dm_interface_init, }; -void (*_exits[])(void ) __exitdata = { +void (*_exits[])(void ) = { local_exit, dm_target_exit, dm_linear_exit,
Alasdair G Kergon
maintainerQuoted 2 lines · Andries Brouwer
Yes - thanks for reminding - thought of that yesterday night but forgot again the next morning.
Also, because one ordered list has been replaced by two, please add a comment to warn anyone editing either list of functions that the two ordered lists must correspond: every function in _inits must have an exit function in the corresponding position in _exits.
The macro looked pretty horrid, but did you consider just expanding it out?
Alasdair
Alasdair G Kergon
maintainerQuoted 5 lines · Andries Brouwer
Quoted 2 lines · Keith Owens
drivers/md/dm.cdm_intrefers to_exitswhich is defined as__exitdata. WithCONFIG_HOTPLUG=n,__exitdatais discardedYes - thanks for reminding - thought of that yesterday night but forgot again the next morning.
In fact that's the second time someone's introduced a bug like that in this code: to save someone else from doing it again, please also add a comment that the exit functions may be called during init (if an init function fails).
Alasdair
Signature · 1 line
[email protected]