Skip to contentSkip to conversation

2.4.28-rc3: neigh_for_each must be EXPORT_SYMBOL'ed

PATCH New O.Sezer 3 participants 3 messages Nov 15, 2004 Networking

lore
Share & tools
lore

O.Sezer

author
#0 lore raw

A similar export should also be needed for __neigh_for_each_release :

/sbin/depmod -ae -F System.map 2.4.28-rc3aac2
depmod: *** Unresolved symbols in /lib/modules/2.4.28-rc3aac2/kernel/net/atm/clip.o
depmod: __neigh_for_each_release

Ozkan Sezer

#1 lore raw

PATCH 1/1 2.4.28-rc3: __neigh_for_each_release must be EXPORT_SYMBOL'ed

Quoted 6 lines · O.Sezer

A similar export should also be needed for __neigh_for_each_release :

/sbin/depmod -ae -F System.map 2.4.28-rc3aac2
depmod: *** Unresolved symbols in
/lib/modules/2.4.28-rc3aac2/kernel/net/atm/clip.o
depmod: __neigh_for_each_release

Thanks for this report.

For some strange reason, this wasn't covered by the modular .config I used for testing...

Patch (on top of my other patch) below.

Signed-off-by Adrian Bunk <[email protected]>
net/core/neighbour.c renamed from net/core/neighbour.c.old +1 -0
@@ -1597,6 +1597,7 @@
 		}
 	}
 }
+EXPORT_SYMBOL(__neigh_for_each_release);
 
 #ifdef CONFIG_PROC_FS
maintainer
#2 lore raw
In reply to O.Sezer
Quoted 6 lines · On Mon, 15 Nov 2004 17:27:56 +0200 "O.Sezer" <[email protected]> wrote:

A similar export should also be needed for __neigh_for_each_release :

/sbin/depmod -ae -F System.map 2.4.28-rc3aac2
depmod: *** Unresolved symbols in
/lib/modules/2.4.28-rc3aac2/kernel/net/atm/clip.o
depmod: __neigh_for_each_release

Good catch, I've fixed this in my tree and will push upstream.