MODULE_PARM in drivers/net/ppp_async.c

Hi.
Compiling 2.6.10-rc2 with ppp_async.ko I saw a warning about MODULE_PARAM.
I do not know a lot on this topic, anyway I searched a bit about that and tried to patch the ppp_async.c file.
I compiled (without getting the previous warning) and tested ppp with the attached patch.
Please let me know if it is the proper way to patch it. Thank you.

Carlo Perassi - http://www.linux.it/~carlo/

---

@@ -84,7 +84,7 @@ struct asyncppp {
 #define SC_RCV_BITS	(SC_RCV_B7_1|SC_RCV_B7_0|SC_RCV_ODDP|SC_RCV_EVNP)
 
 static int flag_time = HZ;
-MODULE_PARM(flag_time, "i");
+module_param(flag_time, int, 0444);
 MODULE_PARM_DESC(flag_time, "ppp_async: interval between flagged packets (in clock ticks)");
 MODULE_LICENSE("GPL");
 MODULE_ALIAS_LDISC(N_PPP);

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors