Skip to contentSkip to conversation

drivers/video/gbefb.c

PATCH In review Giuseppe Sacco 2 participants 2 messages Nov 18, 2004 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/video/gbefb.c

The current gbefb.c source cannot be compiled as module because of a small typo where "option" was written instead of "options" in two places.

Here is a small patch that fixes it. May anyone apply it?

Thanks,
Giuseppe

Index: gbefb.c
===================================================================
RCS file: /home/cvs/linux/drivers/video/gbefb.c,v
retrieving revision 1.11
diff -r1.11 gbefb.c
1121c1121
< char *option = NULL;
---

Quoted 1 line
	char *options = NULL;

1123c1123
< if (fb_get_options("gbefb", &option))
---

Quoted 1 line
	if (fb_get_options("gbefb", &options))
#1 lore raw
Quoted 6 lines · Giuseppe Sacco

The current gbefb.c source cannot be compiled as module because of a
small typo where "option" was written instead of "options" in two places.

Here is a small patch that fixes it. May anyone apply it?

Yup, I can take care of that, thanks.

In future, please use diff -u' to generate patch -p1' form patches. Like this:

drivers/video/gbefb.c +2 -2
@@ -1084,9 +1084,9 @@ int __init gbefb_init(void)
 	int i, ret = 0;
 
 #ifndef MODULE
-	char *option = NULL;
+	char *options = NULL;
 
-	if (fb_get_options("gbefb", &option))
+	if (fb_get_options("gbefb", &options))
 		return -ENODEV;
 	gbefb_setup(options);
 #endif

_