kill locking around scsi_done()

PATCH New Jens Axboe 1 participant 1 message Nov 22, 2004 SCSI

lore

Share & tools

lore

Jens Axboe

author

2004-11-22 08:08 UTC #0 lore raw

PATCH 1/1 kill locking around scsi_done()

Hi,

Lets show the mid layer as a good example and remove the host lock around the scsi_done() call.

Signed-off-by Jens Axboe <[email protected]>

===== drivers/scsi/scsi.c 1.148 vs edited =====

drivers/scsi/scsi.c +0 -2

@@ -606,9 +606,7 @@
 				printk("queuecommand : command too long.\n"));
 		cmd->result = (DID_ABORT << 16);
 
-		spin_lock_irqsave(host->host_lock, flags);
 		scsi_done(cmd);
-		spin_unlock_irqrestore(host->host_lock, flags);
 		goto out;
 	}

Signature · 1 line

Jens Axboe