Skip to contentSkip to conversation

x86_64 hardirq.h: no need to #ifdef CONFIG_X86

PATCH In review Adrian Bunk 2 participants 2 messages Nov 24, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86_64 hardirq.h: no need to #ifdef CONFIG_X86

I can't see any reason for the #ifdef CONFIG_X86 introduced to the x86_64 hardirq.h as part of the generic irq subsystem changes.

include/asm-x86_64/hardirq.h renamed from include/asm-x86_64/hardirq.h.old +0 -2
@@ -21,7 +21,6 @@
  */
 static inline void ack_bad_irq(unsigned int irq)
 {
-#ifdef CONFIG_X86
 	printk("unexpected IRQ trap at vector %02x\n", irq);
 #ifdef CONFIG_X86_LOCAL_APIC
 	/*
@@ -34,6 +33,5 @@
 	 */
 	ack_APIC_irq();
 #endif
-#endif
 }
 #endif /* __ASM_HARDIRQ_H */
#1 lore raw
Quoted 3 lines · Adrian Bunk

I can't see any reason for the #ifdef CONFIG_X86 introduced to the x86_64 hardirq.h as part of the generic irq subsystem changes.

Looks good thanks. I added it to my patchkit.

-Andi