Skip to contentSkip to conversation

v4l: fix permissions on module parameters exported via sysfs

PATCH New Dmitry Torokhov 1 participant 1 message Nov 25, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 v4l: fix permissions on module parameters exported via sysfs

Another case of 0 missing from octal encoding.

Signature · 56 lines
Dmitry


===================================================================


[email protected], 2004-11-25 00:40:44-05:00, [email protected]
  v4l: Fix permissions on module parameters exported via sysfs.
  
  Signed-off-by: Dmitry Torokhov <[email protected]>


 tuner.c |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)


===================================================================



diff -Nru a/drivers/media/video/tuner.c b/drivers/media/video/tuner.c
--- a/drivers/media/video/tuner.c	2004-11-25 01:27:47 -05:00
+++ b/drivers/media/video/tuner.c	2004-11-25 01:27:47 -05:00
@@ -30,24 +30,24 @@
 /* insmod options used at init time => read/only */
 static unsigned int type  =  UNSET;
 static unsigned int addr  =  0;
-module_param(type, int, 444);
-module_param(addr, int, 444);
+module_param(type, int, 0444);
+module_param(addr, int, 0444);
 
 /* insmod options used at runtime => read/write */
 static unsigned int debug         = 0;
 static unsigned int tv_antenna    = 1;
 static unsigned int radio_antenna = 0;
 static unsigned int optimize_vco  = 1;
-module_param(debug,             int, 644);
-module_param(tv_antenna,        int, 644);
-module_param(radio_antenna,     int, 644);
-module_param(optimize_vco,      int, 644);
+module_param(debug,             int, 0644);
+module_param(tv_antenna,        int, 0644);
+module_param(radio_antenna,     int, 0644);
+module_param(optimize_vco,      int, 0644);
 
 static unsigned int tv_range[2]    = { 44, 958 };
 static unsigned int radio_range[2] = { 65, 108 };
 
-module_param_array(tv_range,    int, NULL, 644);
-module_param_array(radio_range, int, NULL, 644);
+module_param_array(tv_range,    int, NULL, 0644);
+module_param_array(radio_range, int, NULL, 0644);
 
 MODULE_DESCRIPTION("device driver for various TV and TV+FM radio tuners");
 MODULE_AUTHOR("Ralph Metzler, Gerd Knorr, Gunther Mayer");