select for drivers/mtd
Subsystems (2)
PATCH 1/1 select for drivers/mtd
The patch below switches options to use select where appropriate.
One of the dependencies of MTD_GEN_PROBE was on MTD_INTELPROBE that isn't in Linus' tree. If this symbol is present in the mtd cvs, a similar select is needed there.
What's the purpose of the MTD_DOCECC option, which has always the same value as the MTD_DOCPROBE option?
diffstat output:
drivers/mtd/chips/Kconfig | 9 +++++---- drivers/mtd/devices/Kconfig | 15 +++++++-------- drivers/mtd/nand/Kconfig | 3 +-- 3 files changed, 13 insertions(+), 14 deletions(-)
Signed-off-by Adrian Bunk <[email protected]>
drivers/mtd/chips/Kconfig renamed from drivers/mtd/chips/Kconfig.old +5 -4
@@ -7,6 +7,7 @@ config MTD_CFI tristate "Detect flash chips by Common Flash Interface (CFI) probe" depends on MTD + select MTD_GEN_PROBE help The Common Flash Interface specification was developed by Intel, AMD and other flash manufactures that provides a universal method
@@ -18,6 +19,7 @@ config MTD_JEDECPROBE tristate "Detect non-CFI AMD/JEDEC-compatible flash chips" depends on MTD + select MTD_GEN_PROBE help This option enables JEDEC-style probing of flash chips which are not compatible with the Common Flash Interface, but will use the common
@@ -29,8 +31,6 @@ config MTD_GEN_PROBE tristate - default m if MTD_CFI!=y && !MTD_INTELPROBE && MTD_JEDECPROBE!=y && (MTD_CFI=m || MTD_JEDECPROBE=m) - default y if MTD_CFI=y || MTD_INTELPROBE || MTD_JEDECPROBE=y config MTD_CFI_ADV_OPTIONS bool "Flash chip driver advanced configuration options"
@@ -158,6 +158,7 @@ config MTD_CFI_INTELEXT tristate "Support for Intel/Sharp flash chips" depends on MTD_GEN_PROBE + select MTD_CFI_UTIL help The Common Flash Interface defines a number of different command sets which a CFI-compliant chip may claim to implement. This code
@@ -167,6 +168,7 @@ config MTD_CFI_AMDSTD tristate "Support for AMD/Fujitsu flash chips" depends on MTD_GEN_PROBE + select MTD_CFI_UTIL help The Common Flash Interface defines a number of different command sets which a CFI-compliant chip may claim to implement. This code
@@ -197,6 +199,7 @@ config MTD_CFI_STAA tristate "Support for ST (Advanced Architecture) flash chips" depends on MTD_GEN_PROBE + select MTD_CFI_UTIL help The Common Flash Interface defines a number of different command sets which a CFI-compliant chip may claim to implement. This code
@@ -204,8 +207,6 @@ config MTD_CFI_UTIL tristate - default y if MTD_CFI_INTELEXT=y || MTD_CFI_AMDSTD=y || MTD_CFI_STAA=y - default m if MTD_CFI_INTELEXT=m || MTD_CFI_AMDSTD=m || MTD_CFI_STAA=m config MTD_RAM tristate "Support for RAM chips in bus mapping"
drivers/mtd/devices/Kconfig renamed from drivers/mtd/devices/Kconfig.old +7 -8
@@ -130,6 +130,8 @@ config MTD_DOC2000 tristate "M-Systems Disk-On-Chip 2000 and Millennium (DEPRECATED)" depends on MTD + select MTD_DOCPROBE + select MTD_NAND_IDS ---help--- This provides an MTD device driver for the M-Systems DiskOnChip 2000 and Millennium devices. Originally designed for the DiskOnChip
@@ -151,6 +153,8 @@ config MTD_DOC2001 tristate "M-Systems Disk-On-Chip Millennium-only alternative driver (DEPRECATED)" depends on MTD + select MTD_DOCPROBE + select MTD_NAND_IDS ---help--- This provides an alternative MTD device driver for the M-Systems DiskOnChip Millennium devices. Use this if you have problems with
@@ -171,6 +175,8 @@ config MTD_DOC2001PLUS tristate "M-Systems Disk-On-Chip Millennium Plus" depends on MTD + select MTD_DOCPROBE + select MTD_NAND_IDS ---help--- This provides an MTD device driver for the M-Systems DiskOnChip Millennium Plus devices.
@@ -186,17 +192,10 @@ config MTD_DOCPROBE tristate - default m if MTD_DOC2001!=y && MTD_DOC2000!=y && MTD_DOC2001PLUS!=y && (MTD_DOC2001=m || MTD_DOC2000=m || MTD_DOC2001PLUS=m) - default y if MTD_DOC2001=y || MTD_DOC2000=y || MTD_DOC2001PLUS=y - help - This isn't a real config option; it's derived. + select MTD_DOCECC config MTD_DOCECC tristate - default m if MTD_DOCPROBE=m - default y if MTD_DOCPROBE=y - help - This isn't a real config option; it's derived. config MTD_DOCPROBE_ADVANCED bool "Advanced detection options for DiskOnChip"
drivers/mtd/nand/Kconfig renamed from drivers/mtd/nand/Kconfig.old +1 -2
@@ -7,6 +7,7 @@ config MTD_NAND tristate "NAND Device Support" depends on MTD + select MTD_NAND_IDS help This enables support for accessing all type of NAND flash devices. For further information see
@@ -56,8 +57,6 @@ config MTD_NAND_IDS tristate - default y if MTD_NAND = y || MTD_DOC2000 = y || MTD_DOC2001 = y || MTD_DOC2001PLUS = y - default m if MTD_NAND = m || MTD_DOC2000 = m || MTD_DOC2001 = m || MTD_DOC2001PLUS = m config MTD_NAND_TX4925NDFMC tristate "SmartMedia Card on Toshiba RBTX4925 reference board"
Quoted 1 line · Adrian Bunk
The patch below switches options to use select where appropriate.
Thanks. Applied to bk://linux-mtd.bkbits.net/mtd-2.6 to go in after 2.6.10
Quoted 3 lines
One of the dependencies of
MTD_GEN_PROBEwas onMTD_INTELPROBEthat isn't in Linus' tree. If this symbol is present in the mtd cvs, a similar select is needed there.
It's gone now; removing it was correct.
Quoted 2 lines
What's the purpose of the
MTD_DOCECCoption, which has always the same value as theMTD_DOCPROBEoption?
It's obsolescent. The new DiskOnChip hardware driver was recently converted from using it, in favour of the new Reed-Solomon library code. Some day relatively soon the old hardware driver can go too, but not yet. It's probably not worth converting that to the new ECC code.
Signature · 1 line
dwmw2