Skip to contentSkip to conversation

ALSA: remove unused functions (fwd)

PATCH In review Adrian Bunk 2 participants 3 messages Nov 29, 2004 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: remove unused functions (fwd)

The patch forwarded below still applies and compiles against 2.6.10-rc2-mm3.

Please apply or comment on it.

----- Forwarded message from Adrian Bunk <[email protected]> -----

Date: Fri, 29 Oct 2004 02:14:04 +0200
From: Adrian Bunk <[email protected]>
To: [email protected]
Cc: [email protected], [email protected]
Subject: [2.6 patch] ALSA: remove unused functions

[ this time without the problems due to a digital signature... ]

The patch below removes two unused ALSA functions.

diffstat output:

 sound/pci/cmipci.c             |    7 +------
 sound/pci/ymfpci/ymfpci_main.c |    5 -----
 2 files changed, 1 insertion(+), 11 deletions(-)
sound/pci/cmipci.c renamed from sound/pci/cmipci.c.old +1 -6
@@ -499,17 +499,12 @@
 	return inw(cm->iobase + cmd);
 }
 
-/* read/write operations for byte register */
+/* write operations for byte register */
 inline static void snd_cmipci_write_b(cmipci_t *cm, unsigned int cmd, unsigned char data)
 {
 	outb(data, cm->iobase + cmd);
 }
 
-inline static unsigned char snd_cmipci_read_b(cmipci_t *cm, unsigned int cmd)
-{
-	return inb(cm->iobase + cmd);
-}
-
 /* bit operations for dword register */
 static void snd_cmipci_set_bit(cmipci_t *cm, unsigned int cmd, unsigned int flag)
 {
sound/pci/ymfpci/ymfpci_main.c renamed from sound/pci/ymfpci/ymfpci_main.c.old +0 -5
@@ -52,11 +52,6 @@
 
 static void snd_ymfpci_irq_wait(ymfpci_t *chip);
 
-static inline u8 snd_ymfpci_readb(ymfpci_t *chip, u32 offset)
-{
-	return readb(chip->reg_area_virt + offset);
-}
-
 static inline void snd_ymfpci_writeb(ymfpci_t *chip, u32 offset, u8 val)
 {
 	writeb(val, chip->reg_area_virt + offset);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

----- End forwarded message -----

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/

#1 lore raw

At Mon, 29 Nov 2004 03:29:35 +0100,

Quoted 6 lines · Adrian Bunk

The patch forwarded below still applies and compiles against 2.6.10-rc2-mm3.

Please apply or comment on it.

Well, I don't think that it will bring much gain to remove such small inline functions... Just my feeling, no particular objection, though.

Takashi

Quoted 68 lines

----- Forwarded message from Adrian Bunk <[email protected]> -----

Date: Fri, 29 Oct 2004 02:14:04 +0200
From: Adrian Bunk <[email protected]>
To: [email protected]
Cc: [email protected], [email protected]
Subject: [2.6 patch] ALSA: remove unused functions

[ this time without the problems due to a digital signature... ]

The patch below removes two unused ALSA functions.

diffstat output:

 sound/pci/cmipci.c             |    7 +------
 sound/pci/ymfpci/ymfpci_main.c |    5 -----
 2 files changed, 1 insertion(+), 11 deletions(-)
sound/pci/cmipci.c renamed from sound/pci/cmipci.c.old +1 -6
@@ -499,17 +499,12 @@
 	return inw(cm->iobase + cmd);
 }
 
-/* read/write operations for byte register */
+/* write operations for byte register */
 inline static void snd_cmipci_write_b(cmipci_t *cm, unsigned int cmd, unsigned char data)
 {
 	outb(data, cm->iobase + cmd);
 }
 
-inline static unsigned char snd_cmipci_read_b(cmipci_t *cm, unsigned int cmd)
-{
-	return inb(cm->iobase + cmd);
-}
-
 /* bit operations for dword register */
 static void snd_cmipci_set_bit(cmipci_t *cm, unsigned int cmd, unsigned int flag)
 {
sound/pci/ymfpci/ymfpci_main.c renamed from sound/pci/ymfpci/ymfpci_main.c.old +0 -6
@@ -52,11 +52,6 @@
 
 static void snd_ymfpci_irq_wait(ymfpci_t *chip);
 
-static inline u8 snd_ymfpci_readb(ymfpci_t *chip, u32 offset)
-{
-	return readb(chip->reg_area_virt + offset);
-}
-
 static inline void snd_ymfpci_writeb(ymfpci_t *chip, u32 offset, u8 val)
 {
 	writeb(val, chip->reg_area_virt + offset);
-

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

----- End forwarded message -----

Quoted 10 lines

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/

#2 lore raw
In reply to Adrian Bunk

At Mon, 29 Nov 2004 03:29:35 +0100,

Quoted 6 lines · Adrian Bunk

The patch forwarded below still applies and compiles against 2.6.10-rc2-mm3.

Please apply or comment on it.

Well, I don't think that it will bring much gain to remove such small inline functions... Just my feeling, no particular objection, though.

Takashi

Quoted 78 lines

----- Forwarded message from Adrian Bunk <[email protected]> -----

Date: Fri, 29 Oct 2004 02:14:04 +0200
From: Adrian Bunk <[email protected]>
To: [email protected]
Cc: [email protected], [email protected]
Subject: [2.6 patch] ALSA: remove unused functions

[ this time without the problems due to a digital signature... ]

The patch below removes two unused ALSA functions.

diffstat output:

 sound/pci/cmipci.c             |    7 +------
 sound/pci/ymfpci/ymfpci_main.c |    5 -----
 2 files changed, 1 insertion(+), 11 deletions(-)
sound/pci/cmipci.c renamed from sound/pci/cmipci.c.old +1 -6
@@ -499,17 +499,12 @@
 	return inw(cm->iobase + cmd);
 }
 
-/* read/write operations for byte register */
+/* write operations for byte register */
 inline static void snd_cmipci_write_b(cmipci_t *cm, unsigned int cmd, unsigned char data)
 {
 	outb(data, cm->iobase + cmd);
 }
 
-inline static unsigned char snd_cmipci_read_b(cmipci_t *cm, unsigned int cmd)
-{
-	return inb(cm->iobase + cmd);
-}
-
 /* bit operations for dword register */
 static void snd_cmipci_set_bit(cmipci_t *cm, unsigned int cmd, unsigned int flag)
 {
sound/pci/ymfpci/ymfpci_main.c renamed from sound/pci/ymfpci/ymfpci_main.c.old +0 -6
@@ -52,11 +52,6 @@
 
 static void snd_ymfpci_irq_wait(ymfpci_t *chip);
 
-static inline u8 snd_ymfpci_readb(ymfpci_t *chip, u32 offset)
-{
-	return readb(chip->reg_area_virt + offset);
-}
-
 static inline void snd_ymfpci_writeb(ymfpci_t *chip, u32 offset, u8 val)
 {
 	writeb(val, chip->reg_area_virt + offset);
-

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

----- End forwarded message -----

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel