Skip to contentSkip to conversation

cry[to/ : make some code static

PATCH In review Adrian Bunk 3 participants 3 messages Nov 29, 2004 – Dec 1, 2004 Crypto API

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 cry[to/ : make some code static

The patch below makes some needlessly global code static.

diffstat output:

 crypto/sha512.c |    2 
 crypto/tcrypt.c |    2 
 crypto/tcrypt.h |  102 ++++++++++++++++++++++++------------------------
 3 files changed, 53 insertions(+), 53 deletions(-)
Signed-off-by Adrian Bunk <[email protected]>
crypto/sha512.c renamed from crypto/sha512.c.old +1 -1
@@ -48,7 +48,7 @@
         return (x >> y) | (x << (64 - y));
 }
 
-const u64 sha512_K[80] = {
+static const u64 sha512_K[80] = {
         0x428a2f98d728ae22ULL, 0x7137449123ef65cdULL, 0xb5c0fbcfec4d3b2fULL,
         0xe9b5dba58189dbbcULL, 0x3956c25bf348b538ULL, 0x59f111f1b605d019ULL,
         0x923f82a4af194f9bULL, 0xab1c5ed5da6d8118ULL, 0xd807aa98a3030242ULL,
crypto/tcrypt.h renamed from crypto/tcrypt.h.old +51 -51

408 lines not on this page · raw message

crypto/tcrypt.c renamed from crypto/tcrypt.c.old +1 -1
@@ -255,7 +255,7 @@
 
 #endif	/* CONFIG_CRYPTO_HMAC */
 
-void
+static void
 test_cipher(char * algo, int mode, int enc, struct cipher_testvec * template, unsigned int tcount)
 {
 	unsigned int ret, i, j, k, temp;
#1 lore raw
Quoted 1 line · Adrian Bunk

The patch below makes some needlessly global code static.

Looks fine to me.

- James

Signature · 2 lines
James Morris
<[email protected]>
maintainer
#2 lore raw
Quoted 5 lines · On Mon, 29 Nov 2004 10:39:32 -0500 (EST) James Morris <[email protected]>…
Quoted 1 line · Adrian Bunk

The patch below makes some needlessly global code static.

Looks fine to me.

I'll queue this up for 2.6.11, thanks Adrian.