Skip to contentSkip to conversation

remove dp83840.h

PATCH In review Adrian Bunk 3 participants 4 messages Nov 29, 2004 – Dec 2, 2004

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove dp83840.h

dp83840.h is included once but none of the definitions it contains is actually used.

Is the patch below to remove it OK, or is there any usage planned?

diffstat output:

 drivers/net/ioc3-eth.c  |    1 
 include/linux/dp83840.h |   41 ----------------------------------------
 2 files changed, 42 deletions(-)
drivers/net/ioc3-eth.c renamed from drivers/net/ioc3-eth.c.old +0 -1
@@ -56,7 +56,6 @@
 #include <linux/etherdevice.h>
 #include <linux/ethtool.h>
 #include <linux/skbuff.h>
-#include <linux/dp83840.h>
 #include <net/ip.h>
 
 #include <asm/byteorder.h>
include/linux/dp83840.h deleted +0 -41

41 lines not on this page · raw message

#1 lore raw
Quoted 4 lines · Adrian Bunk

dp83840.h is included once but none of the definitions it contains is actually used.

Is the patch below to remove it OK, or is there any usage planned?

I would suggest to keep the file as documentation of the DP83840.

Ralf

#2 lore raw
Quoted 8 lines · Ralf Baechle
Quoted 4 lines · Adrian Bunk

dp83840.h is included once but none of the definitions it contains is actually used.

Is the patch below to remove it OK, or is there any usage planned?

I would suggest to keep the file as documentation of the DP83840.

What about moving it to Documentation/ ?

Quoted 1 line

Ralf

cu
Adrian

diffstat output:

 Documentation/networking/00-INDEX    |    2 +
 Documentation/networking/dp83840.txt |   41 +++++++++++++++++++++++++++
 drivers/net/ioc3-eth.c               |    1 
 include/linux/dp83840.h              |   41 ---------------------------
 4 files changed, 43 insertions(+), 42 deletions(-)
drivers/net/ioc3-eth.c renamed from drivers/net/ioc3-eth.c.old +0 -1
@@ -56,7 +56,6 @@
 #include <linux/etherdevice.h>
 #include <linux/ethtool.h>
 #include <linux/skbuff.h>
-#include <linux/dp83840.h>
 #include <net/ip.h>
 
 #include <asm/byteorder.h>
include/linux/dp83840.h deleted +0 -41

41 lines not on this page · raw message

Documentation/networking/dp83840.txt new file +41 -0

41 lines not on this page · raw message

Documentation/networking/00-INDEX renamed from Documentation/networking/00-INDEX.old +2 -0
@@ -42,6 +42,8 @@
 	- the Digi International RightSwitch SE-X Ethernet driver
 dmfe.txt
 	- info on the Davicom DM9102(A)/DM9132/DM9801 fast ethernet driver.
+dp83840.txt
+	- the former dp83840.h
 e100.txt
 	- info on Intel's EtherExpress PRO/100 line of 10/100 boards
 e1000.txt