Skip to contentSkip to conversation

DECnet typo in accept causes oops

PATCH Applied Patrick Caulfield 2 participants 2 messages Nov 29, 2004 – Nov 30, 2004 Networking

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 DECnet typo in accept causes oops

This patch fixes typo which can cause a rare oops in accept. dn_accept returns a pointer instead of an error if dn_wait_for_connect() is interrupted. This confuses sys_accept which calls dn_getname with a incomplete struct socket, this then oopses.

patrick

===== net/decnet/af_decnet.c 1.45 vs edited =====

net/decnet/af_decnet.c +1 -1
@@ -1075,7 +1075,7 @@ static int dn_accept(struct socket *sock
 		skb = dn_wait_for_connect(sk, &timeo);
 		if (IS_ERR(skb)) {
 			release_sock(sk);
-			return PTR_ERR(sk);
+			return PTR_ERR(skb);
 		}
 	}
 
maintainer Applied
#1 lore raw
Quoted 4 lines · On Mon, 29 Nov 2004 16:05:22 +0000 Patrick Caulfield <[email protected]>…

This patch fixes typo which can cause a rare oops in accept. dn_accept returns a pointer instead of an error if dn_wait_for_connect() is interrupted. This confuses sys_accept which calls dn_getname with a incomplete struct socket, this then oopses.

Applied, thanks Patrick.