Skip to contentSkip to conversation

ibmvscsi.c: replace schedule_timeout() with msleep()

PATCH NAK Dave C Boutcher 1 participant 1 message Nov 29, 2004

Subsystems (3)
SCSI PowerPC IBM Power Virtual SCSI Device Drivers
lore
Share & tools
lore

Dave C Boutcher

author
#0 lore raw

PATCH 1/4 ibmvscsi.c: replace schedule_timeout() with msleep()

Description: Use msleep() instead of schedule_timeout() to guarantee the task delays as expected. Originally submitted to linux-scsi by the janitors, and resubmitted by boutcher (after testing :-)

Signed-off-by Nishanth Aravamudan <[email protected]>
Signed-off-by Maximilian Attems <[email protected]>
Signed-off-by Dave Boutcher <[email protected]>

---

 linux-2.6.9-max/drivers/scsi/ibmvscsi/ibmvscsi.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/ibmvscsi/ibmvscsi.c renamed from drivers/scsi/ibmvscsi/ibmvscsi.c~msleep-drivers_scsi_ibmvscsi +2 -2
diff -puN drivers/scsi/ibmvscsi/ibmvscsi.c~msleep-drivers_scsi_ibmvscsi drivers/scsi/ibmvscsi/ibmvscsi.c
@@ -69,6 +69,7 @@
 #include <linux/module.h>
 #include <linux/moduleparam.h>
 #include <linux/dma-mapping.h>
+#include <linux/delay.h>
 #include <asm/vio.h>
 #include <scsi/scsi.h>
 #include <scsi/scsi_cmnd.h>

@@ -1327,8 +1328,7 @@ static int ibmvscsi_probe(struct vio_dev
 		     time_before(jiffies, wait_switch) &&
 		     atomic_read(&hostdata->request_limit) < 0;) {
 
-			set_current_state(TASK_UNINTERRUPTIBLE);
-			schedule_timeout(HZ / 100);
+			msleep(10);
 		}
 
 		/* if we now have a valid request_limit, initiate a scan */
Signature · 1 line
Dave Boutcher