Skip to contentSkip to conversation

Diskdump 1.0 Release

PATCH Itsuro Oda 2 participants 3 messages Nov 30, 2004 – Dec 1, 2004

lore
Share & tools
lore

Itsuro Oda

author
#0 lore raw

Hi,

I am a developer of an yet another crash dump (mkdump). I'd like to know conditions which cause taking dump fail. It is helpful to share those informations for dump developers.

I have three major concerns about taking dump.
* interrupt disable
taking dump should be run under interrput disable. diskdump is aware of that. How about kexec based dump ?
* avoid deadlock
taking dump should not get any locks to avoid deadlock. (?) I think there are many posibility of deadlock in the kexec based dump (from crash occur to initiate the new kernel). (mkdump does not meet neither yet. :-p)
* be sure to get the other CPUs' register value
How are the other CPUs' regsiter value get and how are the other CPUs stoped ?
(of course the goal of mkdump is to solve these points
although not implemented yet :-)

Any other points to be consider ?
Comments and suggestions are welcome.

Thank you.

Signature · 1 line
Itsuro ODA <[email protected]>
#1 lore raw

Hi,

Quoted 6 lines · Itsuro Oda

Hi,

I am a developer of an yet another crash dump (mkdump). I'd like to know conditions which cause taking dump fail. It is helpful to share those informations for dump developers.

Quoted 9 lines

I have three major concerns about taking dump.
* interrupt disable
taking dump should be run under interrput disable. diskdump is aware of that. How about kexec based dump ?
* avoid deadlock
taking dump should not get any locks to avoid deadlock. (?) I think there are many posibility of deadlock in the kexec based dump (from crash occur to initiate the new kernel). (mkdump does not meet neither yet. :-p)

Now kexec based dump is in -mm tree. Could you please have a look at the code and point out if any problems you see.

Quoted 3 lines

* be sure to get the other CPUs' register value How are the other CPUs' regsiter value get and how are the other CPUs stoped ?

Kexec based dump does capture the other CPU's register values.

Quoted 7 lines

(of course the goal of mkdump is to solve these points
although not implemented yet :-)

Any other points to be consider ?
Comments and suggestions are welcome.

Thank you.

Thanks
Vivek

author
#2 lore raw

Hi,

Quoted 3 lines · On 30 Nov 2004 15:56:45 +0530 Vivek Goyal <[email protected]> wrote:

Now kexec based dump is in -mm tree. Could you please have a look at the code and point out if any problems you see.

(I looked 2.6.10-rc1-mm3.)

At first crash_machine_kexec() should be called before bust_spinlock(0) in the panic() function :-)

In disable_IO_APIC() (this is called from crash_dump_stop_cpus()) spin_lock_irqsave(&ioapic_lock, flags) is required. It may be cause a deadlock. (The other CPU may be stoped with this lock hold.)

It seems no lock required except the point mentioned above from crash_machine_kexec called to jumping the new kernel. I feel it is fine.

(BTW. The disconnect_bsp_APIC() in the crash_dump_stop_cpus()
is called twice if both CONFIG_X86_IO_APIC and CONFIG_X86_LOCAL_APIC are set. The code is beter as follows.

#if defined(CONFIG_X86_IO_APIC)
        disable_IO_APIC();
#elif defined(CONFIG_X86_LOCAL_APIC)
        disconnect_bsp_APIC();

#endif
)

Thank you.

Signature · 1 line
Itsuro ODA <[email protected]>