Skip to contentSkip to conversation

[2.4.28] Build Error 2: build of pca200e.bin fails

PATCH In review Manfred Schwarb 3 participants 4 messages Nov 19, 2004 – Dec 1, 2004 ATM

lore
Share & tools
lore
#0 lore raw

Hi,

OK, I know I'm stupid...
I always forget to unset my GZIP options, as I have "export GZIP='-9 -N'" in my .bashrc.

This results in the following:

objcopy -Iihex pca200e.data -Obinary pca200e.bin.gz gzip -df pca200e.bin.gz
./fore200e_mkfirm -k -b _fore200e_pca_fw \
-i pca200e.bin -o fore200e_pca_fw.c
./fore200e_mkfirm: can't open pca200e.bin for reading make[2]: *** [fore200e_pca_fw.c] Error 254
make[2]: Leaving directory `/usr/src/linux-2.4.28/drivers/atm' make[1]: *** [_modsubdir_atm] Error 2
make[1]: Leaving directory `/usr/src/linux-2.4.28/drivers'
make: *** [_mod_drivers] Error 2

The following patch would correct this:

drivers/atm/Makefile renamed from drivers/atm/Makefile.orig +1 -1
@@ -92,7 +92,7 @@
 # deal with the various suffixes of the binary firmware images
 %.bin %.bin1 %.bin2: %.data
 	objcopy -Iihex $< -Obinary [email protected]
-	gzip -df [email protected]
+	gzip -n -df [email protected]
 
 fore_200e.o: $(fore_200e-objs)
 	$(LD) -r -o $@ $(fore_200e-objs)
#1 lore raw

PATCH 1/1 Build Error 2: build of pca200e.bin fails

Quoted 25 lines · Manfred Schwarb

Hi,

OK, I know I'm stupid...
I always forget to unset my GZIP options, as I have "export GZIP='-9 -N'" in my .bashrc.

This results in the following:

objcopy -Iihex pca200e.data -Obinary pca200e.bin.gz gzip -df pca200e.bin.gz
./fore200e_mkfirm -k -b _fore200e_pca_fw \
-i pca200e.bin -o fore200e_pca_fw.c
./fore200e_mkfirm: can't open pca200e.bin for reading make[2]: *** [fore200e_pca_fw.c] Error 254
make[2]: Leaving directory `/usr/src/linux-2.4.28/drivers/atm' make[1]: *** [_modsubdir_atm] Error 2
make[1]: Leaving directory `/usr/src/linux-2.4.28/drivers'
make: *** [_mod_drivers] Error 2

The following patch would correct this:

drivers/atm/Makefile line 98

Quoted 8 lines
drivers/atm/Makefile renamed from drivers/atm/Makefile.orig +1 -1
@@ -92,7 +92,7 @@
 # deal with the various suffixes of the binary firmware images
 %.bin %.bin1 %.bin2: %.data
 	objcopy -Iihex $< -Obinary [email protected]
-	gzip -df [email protected]
+	gzip -n -df [email protected]
 
 fore_200e.o: $(fore_200e-objs)
 	$(LD) -r -o $@ $(fore_200e-objs)

I have no problems with this patch, but shouldn't the same be done in 2.6?

drivers/atm/Makefile renamed from drivers/atm/Makefile.old +1 -1
@@ -68,4 +68,4 @@
 # deal with the various suffixes of the binary firmware images
 $(obj)/%.bin $(obj)/%.bin1 $(obj)/%.bin2: $(src)/%.data
 	objcopy -Iihex $< -Obinary [email protected]
-	gzip -df [email protected]
+	gzip -n -df [email protected]
#2 lore raw

Re: [2.6 patch] Build Error 2: build of pca200e.bin fails

Quoted 45 lines · Adrian Bunk
Quoted 25 lines · Manfred Schwarb

Hi,

OK, I know I'm stupid...
I always forget to unset my GZIP options, as I have "export GZIP='-9 -N'" in my .bashrc.

This results in the following:

objcopy -Iihex pca200e.data -Obinary pca200e.bin.gz gzip -df pca200e.bin.gz
./fore200e_mkfirm -k -b _fore200e_pca_fw \
-i pca200e.bin -o fore200e_pca_fw.c
./fore200e_mkfirm: can't open pca200e.bin for reading make[2]: *** [fore200e_pca_fw.c] Error 254
make[2]: Leaving directory `/usr/src/linux-2.4.28/drivers/atm' make[1]: *** [_modsubdir_atm] Error 2
make[1]: Leaving directory `/usr/src/linux-2.4.28/drivers'
make: *** [_mod_drivers] Error 2

The following patch would correct this:

drivers/atm/Makefile line 98

Quoted 8 lines
drivers/atm/Makefile renamed from drivers/atm/Makefile.orig +1 -1
@@ -92,7 +92,7 @@
 # deal with the various suffixes of the binary firmware images
 %.bin %.bin1 %.bin2: %.data
 	objcopy -Iihex $< -Obinary [email protected]
-	gzip -df [email protected]
+	gzip -n -df [email protected]
 
 fore_200e.o: $(fore_200e-objs)
 	$(LD) -r -o $@ $(fore_200e-objs)

I have no problems with this patch, but shouldn't the same be done in 2.6?

drivers/atm/Makefile line 71

Quoted 5 lines
drivers/atm/Makefile renamed from drivers/atm/Makefile.old +1 -1
@@ -68,4 +68,4 @@
 # deal with the various suffixes of the binary firmware images
 $(obj)/%.bin $(obj)/%.bin1 $(obj)/%.bin2: $(src)/%.data
 	objcopy -Iihex $< -Obinary [email protected]
-	gzip -df [email protected]
+	gzip -n -df [email protected]

Isnt it exactly the same of what has been merged in v2.4?

I can't see any difference.

[marcelo@dmt atm]$ bk diffs -u -r1.8 -r1.9 Makefile ===== Makefile 1.8 vs 1.9 =====

drivers/atm/Makefile Mon Nov 22 21:54:09 2004 renamed from drivers/atm/Makefile Mon Jul 28 11:35:31 2003 +1 -1
@@ -92,7 +92,7 @@
 # deal with the various suffixes of the binary firmware images
 %.bin %.bin1 %.bin2: %.data
        objcopy -Iihex $< -Obinary [email protected]
-       gzip -df [email protected]
+       gzip -n -df [email protected]
 
 fore_200e.o: $(fore_200e-objs)
        $(LD) -r -o $@ $(fore_200e-objs)
#3 lore raw

Re: [2.6 patch] Build Error 2: build of pca200e.bin fails

Quoted 26 lines · Marcelo Tosatti
Quoted 10 lines · Adrian Bunk

I have no problems with this patch, but shouldn't the same be done in 2.6?

drivers/atm/Makefile line 71

Quoted 5 lines
drivers/atm/Makefile renamed from drivers/atm/Makefile.old +1 -1
@@ -68,4 +68,4 @@
 # deal with the various suffixes of the binary firmware images
 $(obj)/%.bin $(obj)/%.bin1 $(obj)/%.bin2: $(src)/%.data
 	objcopy -Iihex $< -Obinary [email protected]
-	gzip -df [email protected]
+	gzip -n -df [email protected]

Isnt it exactly the same of what has been merged in v2.4?

I can't see any difference.

[marcelo@dmt atm]$ bk diffs -u -r1.8 -r1.9 Makefile ===== Makefile 1.8 vs 1.9 =====

drivers/atm/Makefile Mon Nov 22 21:54:09 2004 line 98

Quoted 8 lines
drivers/atm/Makefile Mon Nov 22 21:54:09 2004 renamed from drivers/atm/Makefile Mon Jul 28 11:35:31 2003 +1 -1
@@ -92,7 +92,7 @@
 # deal with the various suffixes of the binary firmware images
 %.bin %.bin1 %.bin2: %.data
        objcopy -Iihex $< -Obinary [email protected]
-       gzip -df [email protected]
+       gzip -n -df [email protected]
 
 fore_200e.o: $(fore_200e-objs)
        $(LD) -r -o $@ $(fore_200e-objs)

It is exactly the same except for the patch context (note that in 2.6, the gzip is the last line of the Makefile).

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed