Skip to contentSkip to conversation

sysfs_dir_close memory leak

PATCH Adam J. Richter 2 participants 2 messages Dec 4, 2004

lore
Share & tools
lore
#0 lore raw
Quoted 2 lines · Greg KH

Thanks, I've deleted the BUG_ON() and will be sending the patch on to Linus in a bit.

Great, thanks.

Quoted 1 line

(oh, care to add a "Signed-off-by:" line to your patches?)

When we first started using Signed-off-by: lines, I did,
and then somebody commented on it to me in some way that gave me the impression that the practice was only for people who "approve" patches, but I'm happy to resume adding Signed-off-by: lines to all of my patches that are proposed for integration in the future.

                    __     ______________

Adam J. Richter \ /
[email protected] | g g d r a s i l

#1 lore raw
Quoted 5 lines · * Adam J. Richter ([email protected]) wrote:

When we first started using Signed-off-by: lines, I did,
and then somebody commented on it to me in some way that gave me the impression that the practice was only for people who "approve" patches, but I'm happy to resume adding Signed-off-by: lines to all of my patches that are proposed for integration in the future.

It's to document the chain. So you, as patch author, should sign off as well as those who "approve" it and send it upstream.

thanks,
-chris

Signature · 1 line
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net