Skip to contentSkip to conversation

2.4.28 config prompts for EXPERIMENTAL features when shouldn't

PATCH In review Mike Castle 4 participants 6 messages Dec 5, 2004 – Dec 9, 2004

Subsystems (3)
SCSI USB libata
lore
Share & tools
lore

Mike Castle

author
#0 lore raw

I have a basic kernel config that I use for boot disks that has CONFIG_EXPERIMENTAL set to no. Yet, with using my old 2.4.26 config with 2.4.28, I'm getting prompted for new experimental features:

NVIDIA SATA support (EXPERIMENTAL) (CONFIG_SCSI_SATA_NV) [N/y/m/?] (NEW) Ethernet Gadget (EXPERIMENTAL) (CONFIG_USB_ETH) [M/n/?]
RNDIS support (EXPERIMENTAL) (CONFIG_USB_ETH_RNDIS) [N/y/?] (NEW)

The fact that CONFIG_USB_ETH was set in my 2.4.26 config seems to indicate this is not a new problem. :->

mrc

Signature · 3 lines
     Mike Castle      [email protected]      www.netcom.com/~dalgoda/
    We are all of us living in the shadow of Manhattan.  -- Watchmen
fatal ("You are in a maze of twisty compiler features, all different"); -- gcc
#1 lore raw
Quoted 10 lines · Mike Castle

I have a basic kernel config that I use for boot disks that has CONFIG_EXPERIMENTAL set to no. Yet, with using my old 2.4.26 config with 2.4.28, I'm getting prompted for new experimental features:

NVIDIA SATA support (EXPERIMENTAL) (CONFIG_SCSI_SATA_NV) [N/y/m/?] (NEW) Ethernet Gadget (EXPERIMENTAL) (CONFIG_USB_ETH) [M/n/?]
RNDIS support (EXPERIMENTAL) (CONFIG_USB_ETH_RNDIS) [N/y/?] (NEW)

The fact that CONFIG_USB_ETH was set in my 2.4.26 config seems to indicate this is not a new problem. :->

Thanks for this report.

The "(EXPERIMENTAL)" string isn't directly coupled to the dependency on EXPERIMENTAL.

I'll send fixes in a minute.

Quoted 1 line

mrc

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#2 lore raw

PATCH 1/1 let SCSI_SATA_NV depend on EXPERIMENTAL

Jeff,

Mike Castle <[email protected]> noticed that CONFIG_SCSI_SATA_NV in 2.4 is marked as "(EXPERIMENTAL)", but doesn't depend on EXPERIMENTAL.

Since it depends on EXPERIMENTAL in 2.6, I'd sugget the patch below to add this dependency in 2.4, too.

Signed-off-by Adrian Bunk <[email protected]>
drivers/scsi/Config.in renamed from drivers/scsi/Config.in.old +1 -1
@@ -72,7 +72,7 @@
 dep_tristate '  AHCI SATA support (EXPERIMENTAL)' CONFIG_SCSI_SATA_AHCI $CONFIG_SCSI_SATA $CONFIG_PCI $CONFIG_EXPERIMENTAL
 dep_tristate '  ServerWorks Frodo / Apple K2 SATA support (EXPERIMENTAL)' CONFIG_SCSI_SATA_SVW $CONFIG_SCSI_SATA $CONFIG_PCI $CONFIG_EXPERIMENTAL
 dep_tristate '  Intel PIIX/ICH SATA support' CONFIG_SCSI_ATA_PIIX $CONFIG_SCSI_SATA $CONFIG_PCI
-dep_tristate '  NVIDIA SATA support (EXPERIMENTAL)' CONFIG_SCSI_SATA_NV $CONFIG_SCSI_SATA $CONFIG_PCI
+dep_tristate '  NVIDIA SATA support (EXPERIMENTAL)' CONFIG_SCSI_SATA_NV $CONFIG_SCSI_SATA $CONFIG_PCI $CONFIG_EXPERIMENTAL
 dep_tristate '  Promise SATA TX2/TX4 support (EXPERIMENTAL)' CONFIG_SCSI_SATA_PROMISE $CONFIG_SCSI_SATA $CONFIG_PCI $CONFIG_EXPERIMENTAL
 dep_tristate '  Promise SATA SX4 support (EXPERIMENTAL)' CONFIG_SCSI_SATA_SX4 $CONFIG_SCSI_SATA $CONFIG_PCI $CONFIG_EXPERIMENTAL
 dep_tristate '  Silicon Image SATA support (EXPERIMENTAL)' CONFIG_SCSI_SATA_SIL $CONFIG_SCSI_SATA $CONFIG_PCI $CONFIG_EXPERIMENTAL
#3 lore raw

Re: [2.4 patch] let SCSI_SATA_NV depend on EXPERIMENTAL

Applied - thanks Adrian.

Quoted 22 lines · Adrian Bunk

Jeff,

Mike Castle <[email protected]> noticed that CONFIG_SCSI_SATA_NV in 2.4 is marked as "(EXPERIMENTAL)", but doesn't depend on EXPERIMENTAL.

Since it depends on EXPERIMENTAL in 2.6, I'd sugget the patch below to add this dependency in 2.4, too.

Signed-off-by Adrian Bunk <[email protected]>
drivers/scsi/Config.in renamed from drivers/scsi/Config.in.old +1 -1
@@ -72,7 +72,7 @@
 dep_tristate '  AHCI SATA support (EXPERIMENTAL)' CONFIG_SCSI_SATA_AHCI $CONFIG_SCSI_SATA $CONFIG_PCI $CONFIG_EXPERIMENTAL
 dep_tristate '  ServerWorks Frodo / Apple K2 SATA support (EXPERIMENTAL)' CONFIG_SCSI_SATA_SVW $CONFIG_SCSI_SATA $CONFIG_PCI $CONFIG_EXPERIMENTAL
 dep_tristate '  Intel PIIX/ICH SATA support' CONFIG_SCSI_ATA_PIIX $CONFIG_SCSI_SATA $CONFIG_PCI
-dep_tristate '  NVIDIA SATA support (EXPERIMENTAL)' CONFIG_SCSI_SATA_NV $CONFIG_SCSI_SATA $CONFIG_PCI
+dep_tristate '  NVIDIA SATA support (EXPERIMENTAL)' CONFIG_SCSI_SATA_NV $CONFIG_SCSI_SATA $CONFIG_PCI $CONFIG_EXPERIMENTAL
 dep_tristate '  Promise SATA TX2/TX4 support (EXPERIMENTAL)' CONFIG_SCSI_SATA_PROMISE $CONFIG_SCSI_SATA $CONFIG_PCI $CONFIG_EXPERIMENTAL
 dep_tristate '  Promise SATA SX4 support (EXPERIMENTAL)' CONFIG_SCSI_SATA_SX4 $CONFIG_SCSI_SATA $CONFIG_PCI $CONFIG_EXPERIMENTAL
 dep_tristate '  Silicon Image SATA support (EXPERIMENTAL)' CONFIG_SCSI_SATA_SIL $CONFIG_SCSI_SATA $CONFIG_PCI $CONFIG_EXPERIMENTAL
#4 lore raw

PATCH 1/1 USB_ETH{,_RNDIS} EXPERIMENTAL dependencies

In reply to Adrian Bunk

Mike Castle <[email protected]> noted that USB_ETH and USB_ETH_RNDIS in 2.4 are marked as "(EXPERIMENTAL)", but don't depend on EXPERIMENTAL.

The patch below removes the "(EXPERIMENTAL)" string from USB_ETH and lets USB_ETH_RNDIS depend on EXPERIMENTAL.

This is similar to the dependencies 2.6 .

Signed-off-by Adrian Bunk <[email protected]>
drivers/usb/gadget/Config.in renamed from drivers/usb/gadget/Config.in.old +2 -2
@@ -52,9 +52,9 @@
   comment 'USB Gadget Drivers'
 
   dep_tristate '  Gadget Zero (DEVELOPMENT)' CONFIG_USB_ZERO $CONFIG_USB_GADGET_CONTROLLER
-  dep_tristate '  Ethernet Gadget (EXPERIMENTAL)' CONFIG_USB_ETH $CONFIG_USB_GADGET_CONTROLLER $CONFIG_NET
+  dep_tristate '  Ethernet Gadget' CONFIG_USB_ETH $CONFIG_USB_GADGET_CONTROLLER $CONFIG_NET
   if [ "$CONFIG_USB_ETH" = "y" -o "$CONFIG_USB_ETH" = "m" ] ; then
-    bool       '    RNDIS support (EXPERIMENTAL)' CONFIG_USB_ETH_RNDIS
+    dep_bool       '    RNDIS support (EXPERIMENTAL)' CONFIG_USB_ETH_RNDIS $CONFIG_EXPERIMENTAL
   fi
   dep_tristate '  File-backed Storage Gadget (DEVELOPMENT)' CONFIG_USB_FILE_STORAGE $CONFIG_USB_GADGET_CONTROLLER
   dep_mbool '    File-backed Storage Gadget test mode' CONFIG_USB_FILE_STORAGE_TEST $CONFIG_USB_FILE_STORAGE
#5 lore raw

Re: [linux-usb-devel] [2.4 patch] USB_ETH{,_RNDIS} EXPERIMENTAL dependencies

Quoted 8 lines · Adrian Bunk

Mike Castle <[email protected]> noted that USB_ETH and USB_ETH_RNDIS in 2.4 are marked as "(EXPERIMENTAL)", but don't depend on EXPERIMENTAL.

The patch below removes the "(EXPERIMENTAL)" string from USB_ETH and lets USB_ETH_RNDIS depend on EXPERIMENTAL.

This is similar to the dependencies 2.6 .

Looks fine to me; go for it!