Skip to contentSkip to conversation

i386/x86_64 msr.c: make two functions static

PATCH In review Adrian Bunk 2 participants 2 messages Dec 6, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i386/x86_64 msr.c: make two functions static

The patch below makes two needlessly global functions static.

diffstat output:

 arch/i386/kernel/msr.c   |    4 ++--
 arch/x86_64/kernel/msr.c |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
arch/i386/kernel/msr.c renamed from arch/i386/kernel/msr.c.old +2 -2
@@ -291,7 +291,7 @@
 	.notifier_call = msr_class_cpu_callback,
 };
 
-int __init msr_init(void)
+static int __init msr_init(void)
 {
 	int i, err = 0;
 	i = 0;
@@ -328,7 +328,7 @@
 	return err;
 }
 
-void __exit msr_exit(void)
+static void __exit msr_exit(void)
 {
 	int cpu = 0;
 	for_each_online_cpu(cpu)
arch/x86_64/kernel/msr.c renamed from arch/x86_64/kernel/msr.c.old +2 -2
@@ -255,7 +255,7 @@
 	.open = msr_open,
 };
 
-int __init msr_init(void)
+static int __init msr_init(void)
 {
 	if (register_chrdev(MSR_MAJOR, "cpu/msr", &msr_fops)) {
 		printk(KERN_ERR "msr: unable to get major %d for msr\n",
@@ -266,7 +266,7 @@
 	return 0;
 }
 
-void __exit msr_exit(void)
+static void __exit msr_exit(void)
 {
 	unregister_chrdev(MSR_MAJOR, "cpu/msr");
 }
#1 lore raw
Quoted 11 lines · Adrian Bunk

The patch below makes two needlessly global functions static.

diffstat output:

 arch/i386/kernel/msr.c   |    4 ++--
 arch/x86_64/kernel/msr.c |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

Looks good to me.