Skip to contentSkip to conversation

bio.c: make bio_destructor static (fwd)

PATCH In review Adrian Bunk 2 participants 2 messages Dec 7, 2004 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bio.c: make bio_destructor static (fwd)

The patch forwarded below still applies and compiles against 2.6.10-rc2-mm4.

Please apply.

----- Forwarded message from Adrian Bunk <[email protected]> -----

Date: Sat, 30 Oct 2004 18:44:50 +0200
From: Adrian Bunk <[email protected]>
To: Jens Axboe <[email protected]>
Cc: [email protected]
Subject: [2.6 patch] bio.c: make bio_destructor static

bio_destructor in fs/bio.c isn't used outside of this file, and after quickly thinking about it I didn't find a reason why it should.

The patch below makes it static.

fs/bio.c renamed from fs/bio.c.old +1 -1
@@ -91,7 +91,7 @@
 /*
  * default destructor for a bio allocated with bio_alloc()
  */
-void bio_destructor(struct bio *bio)
+static void bio_destructor(struct bio *bio)
 {
 	const int pool_idx = BIO_POOL_IDX(bio);
 	struct biovec_pool *bp = bvec_array + pool_idx;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

----- End forwarded message -----

#1 lore raw
Quoted 2 lines · Adrian Bunk

The patch forwarded below still applies and compiles against 2.6.10-rc2-mm4.

Patch is correct, thanks.

Quoted 39 lines

----- Forwarded message from Adrian Bunk <[email protected]> -----

Date: Sat, 30 Oct 2004 18:44:50 +0200
From: Adrian Bunk <[email protected]>
To: Jens Axboe <[email protected]>
Cc: [email protected]
Subject: [2.6 patch] bio.c: make bio_destructor static

bio_destructor in fs/bio.c isn't used outside of this file, and after quickly thinking about it I didn't find a reason why it should.

The patch below makes it static.

fs/bio.c renamed from fs/bio.c.old +1 -2
@@ -91,7 +91,7 @@
 /*
  * default destructor for a bio allocated with bio_alloc()
  */
-void bio_destructor(struct bio *bio)
+static void bio_destructor(struct bio *bio)
 {
 	const int pool_idx = BIO_POOL_IDX(bio);
 	struct biovec_pool *bp = bvec_array + pool_idx;
 
-

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

----- End forwarded message -----

Signature · 1 line
Jens Axboe