Skip to contentSkip to conversation

binfmt_script.c: make struct script_format static (fwd)

PATCH In review Adrian Bunk 2 participants 3 messages Dec 7, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 binfmt_script.c: make struct script_format static (fwd)

The patch forwarded below still applies and compiles against 2.6.10-rc2-mm4.

Please apply.

----- Forwarded message from Adrian Bunk <[email protected]> -----

Date: Sat, 30 Oct 2004 18:42:48 +0200
From: Adrian Bunk <[email protected]>
To: [email protected]
Subject: [2.6 patch] binfmt_script.c: make struct script_format static

The patch below makes struct script_format in fs/binfmt_script.c static.

fs/binfmt_script.c renamed from fs/binfmt_script.c.old +1 -1
@@ -96,7 +96,7 @@
 	return search_binary_handler(bprm,regs);
 }
 
-struct linux_binfmt script_format = {
+static struct linux_binfmt script_format = {
 	.module		= THIS_MODULE,
 	.load_binary	= load_script,
 };

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

----- End forwarded message -----

#1 lore raw
Quoted 4 lines · * Adrian Bunk ([email protected]) wrote:

The patch forwarded below still applies and compiles against 2.6.10-rc2-mm4.

Please apply.

Yup, also binfmt_em86.c (are there any users of it?).

thanks,
-chris

Signature · 19 lines
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net


Make em86_format static.

Signed-off-by: Chris Wright <[email protected]>

===== fs/binfmt_em86.c 1.8 vs edited =====
--- 1.8/fs/binfmt_em86.c	2004-05-10 04:25:55 -07:00
+++ edited/fs/binfmt_em86.c	2004-12-07 12:06:00 -08:00
@@ -95,7 +95,7 @@ static int load_em86(struct linux_binprm
 	return search_binary_handler(bprm, regs);
 }
 
-struct linux_binfmt em86_format = {
+static struct linux_binfmt em86_format = {
 	.module		= THIS_MODULE,
 	.load_binary	= load_em86,
 };
#2 lore raw
Quoted 7 lines · Chris Wright
Quoted 4 lines · * Adrian Bunk ([email protected]) wrote:

The patch forwarded below still applies and compiles against 2.6.10-rc2-mm4.

Please apply.

Yup, also binfmt_em86.c (are there any users of it?).

It's Alpha only.
That's why I didn't find this.

Quoted 11 lines

thanks,
-chris

Make em86_format static.

===== fs/binfmt_em86.c 1.8 vs edited =====

fs/binfmt_em86.c static int load_em86(struct linux_binprm · line 101

Quoted 8 lines
fs/binfmt_em86.c +1 -1
@@ -95,7 +95,7 @@ static int load_em86(struct linux_binprm
 	return search_binary_handler(bprm, regs);
 }
 
-struct linux_binfmt em86_format = {
+static struct linux_binfmt em86_format = {
 	.module		= THIS_MODULE,
 	.load_binary	= load_em86,
 };

Looks good.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed