Skip to contentSkip to conversation

fix ext2/ext3 memory leak

PATCH New Heiko Carstens 1 participant 1 message Dec 9, 2004 ext2 file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix ext2/ext3 memory leak

Hi,

the patch below fixes an ext2/ext3 memory leak: the *_fill_super functions allocate percpu data structures but don't free them in *_put_super.

Thanks,
Heiko

diffstat:

 fs/ext2/super.c |    3 +++
 fs/ext3/super.c |    3 +++
 2 files changed, 6 insertions(+)
fs/ext2/super.c +3 -0
diff -urN linux-2.6/fs/ext2/super.c linux-2.6-patched/fs/ext2/super.c
@@ -122,6 +122,9 @@
 			brelse (sbi->s_group_desc[i]);
 	kfree(sbi->s_group_desc);
 	kfree(sbi->s_debts);
+	percpu_counter_destroy(&sbi->s_freeblocks_counter);
+	percpu_counter_destroy(&sbi->s_freeinodes_counter);
+	percpu_counter_destroy(&sbi->s_dirs_counter);
 	brelse (sbi->s_sbh);
 	sb->s_fs_info = NULL;
 	kfree(sbi);
fs/ext3/super.c +3 -0
diff -urN linux-2.6/fs/ext3/super.c linux-2.6-patched/fs/ext3/super.c
@@ -400,6 +400,9 @@
 	for (i = 0; i < sbi->s_gdb_count; i++)
 		brelse(sbi->s_group_desc[i]);
 	kfree(sbi->s_group_desc);
+	percpu_counter_destroy(&sbi->s_freeblocks_counter);
+	percpu_counter_destroy(&sbi->s_freeinodes_counter);
+	percpu_counter_destroy(&sbi->s_dirs_counter);
 	brelse(sbi->s_sbh);
 #ifdef CONFIG_QUOTA
 	for (i = 0; i < MAXQUOTAS; i++) {