Skip to contentSkip to conversation

arch/i386/pci/: make some code static

PATCH Applied Adrian Bunk 2 participants 2 messages Dec 12, 2004 – Dec 16, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arch/i386/pci/: make some code static

The patch below makes some needlessly global code static.

diffstat output:

 arch/i386/pci/fixup.c |    4 ++--
 arch/i386/pci/irq.c   |    4 +++-
 arch/i386/pci/pci.h   |    2 --
 3 files changed, 5 insertions(+), 5 deletions(-)
arch/i386/pci/fixup.c renamed from arch/i386/pci/fixup.c.old +2 -2
@@ -282,7 +282,7 @@
 	return raw_pci_ops->write(0, bus->number, devfn, where, size, value);
 }
 
-struct pci_ops quirk_pcie_aspm_ops = {
+static struct pci_ops quirk_pcie_aspm_ops = {
 	.read = quirk_pcie_aspm_read,
 	.write = quirk_pcie_aspm_write,
 };
@@ -295,7 +295,7 @@
  * the root port in an array for fast indexing. Replace the bus ops
  * with the modified one.
  */
-void pcie_rootport_aspm_quirk(struct pci_dev *pdev)
+static void pcie_rootport_aspm_quirk(struct pci_dev *pdev)
 {
 	int cap_base, i;
 	struct pci_bus  *pbus;
arch/i386/pci/pci.h renamed from arch/i386/pci/pci.h.old +0 -2
@@ -71,6 +71,4 @@
 extern int pcibios_scanned;
 extern spinlock_t pci_config_lock;
 
-int pirq_enable_irq(struct pci_dev *dev);
-
 extern int (*pcibios_enable_irq)(struct pci_dev *dev);
arch/i386/pci/irq.c renamed from arch/i386/pci/irq.c.old +3 -1
@@ -29,6 +29,8 @@
 
 static struct irq_routing_table *pirq_table;
 
+static int pirq_enable_irq(struct pci_dev *dev);
+
 /*
  * Never use: 0, 1, 2 (timer, keyboard, and cascade)
  * Avoid using: 13, 14 and 15 (FP error and IDE).
@@ -1019,7 +1021,7 @@
 		pirq_penalize_isa_irq(irq);
 }
 
-int pirq_enable_irq(struct pci_dev *dev)
+static int pirq_enable_irq(struct pci_dev *dev)
 {
 	u8 pin;
 	extern int interrupt_line_quirk;
Applied
#1 lore raw
Quoted 8 lines · Adrian Bunk

The patch below makes some needlessly global code static.

diffstat output:

 arch/i386/pci/fixup.c |    4 ++--
 arch/i386/pci/irq.c   |    4 +++-
 arch/i386/pci/pci.h   |    2 --
 3 files changed, 5 insertions(+), 5 deletions(-)

Applied, thanks.

greg k-h