ia64 smpboot.c: remove an unused function

PATCH In review Adrian Bunk 2 participants 3 messages Dec 12, 2004

lore

Share & tools

lore

Adrian Bunk

author

2004-12-12 19:39 UTC #0 lore raw

PATCH 1/1 ia64 smpboot.c: remove an unused function

The patch below removes an unused global functions.

Signed-off-by Adrian Bunk <[email protected]>

arch/ia64/kernel/smpboot.c renamed from arch/ia64/kernel/smpboot.c.old +0 -5

@@ -356,11 +356,6 @@
 	return cpu_idle();
 }
 
-struct pt_regs * __devinit idle_regs(struct pt_regs *regs)
-{
-	return NULL;
-}
-
 struct create_idle {
 	struct task_struct *idle;
 	struct completion done;

Robert Picco

2004-12-12 20:37 UTC #1 lore raw

Quoted 12 lines · Adrian Bunk

The patch below removes an unused global functions.
Signed-off-by Adrian Bunk <[email protected]>
arch/ia64/kernel/smpboot.c renamed from arch/ia64/kernel/smpboot.c.old +0 -0
@@ -356,11 +356,6 @@
 	return cpu_idle();

arch/ia64/kernel/smpboot.c line 361

Quoted 10 lines

arch/ia64/kernel/smpboot.c renamed from arch/ia64/kernel/smpboot.c.old +0 -5

 }
 
-struct pt_regs * __devinit idle_regs(struct pt_regs *regs)
-{
-	return NULL;
-}
-
 struct create_idle {
 	struct task_struct *idle;
 	struct completion done;

I don't believe this is unused. At least not in 2.6.10-rc3. fork_idle requires this function.

Bob

Adrian Bunk

author

2004-12-12 20:41 UTC #2 lore raw

Quoted 15 lines · Robert Picco

Quoted 13 lines · Adrian Bunk
The patch below removes an unused global functions.
Signed-off-by Adrian Bunk <[email protected]>
--- linux-2.6.10-rc2-mm4-full/arch/ia64/kernel/smpboot.c.old 2004-12-12
02:51:04.000000000 +0100
+++ linux-2.6.10-rc2-mm4-full/arch/ia64/kernel/smpboot.c 2004-12-12
02:51:18.000000000 +0100
arch/ia64/kernel/smpboot.c renamed from arch/ia64/kernel/smpboot.c.old +0 -0
@@ -356,11 +356,6 @@
 	return cpu_idle();
 }
 

Quoted 13 lines

arch/ia64/kernel/smpboot.c line 361
Quoted 11 lines
arch/ia64/kernel/smpboot.c renamed from arch/ia64/kernel/smpboot.c.old +0 -5
-struct pt_regs * __devinit idle_regs(struct pt_regs *regs)
-{
-	return NULL;
-}
-
 struct create_idle {
 	struct task_struct *idle;
 	struct completion done;
I don't believe this is unused. At least not in 2.6.10-rc3. fork_idle requires this function.

Ups sorry, you are correct.

For some strange reason I missed.

Quoted 1 line

Bob

Thanks for the correction
Adrian

Signature · 4 lines

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed