Skip to contentSkip to conversation

net/lapb/lapb_iface.c: remove unused code

PATCH In review Adrian Bunk 2 participants 2 messages Dec 15, 2004

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/lapb/lapb_iface.c: remove unused code

The patch below removes the following unused code:
- EXPORT_SYMBOL'ed functions lapb_getparms and lapb_setparms
- struct lapb_parms_struct

Please review whether it's correct or conflicts with pending changes.

diffstat output:

 Documentation/networking/lapb-module.txt |   45 ---------------
 include/linux/lapb.h                     |   14 ----
 net/lapb/lapb_iface.c                    |   67 -----------------------
 3 files changed, 126 deletions(-)
include/linux/lapb.h renamed from include/linux/lapb.h.old +0 -14
@@ -32,22 +32,8 @@
 	void (*data_transmit)(struct net_device *dev, struct sk_buff *skb);
 };
 
-struct lapb_parms_struct {
-	unsigned int t1;
-	unsigned int t1timer;
-	unsigned int t2;
-	unsigned int t2timer;
-	unsigned int n2;
-	unsigned int n2count;
-	unsigned int window;
-	unsigned int state;
-	unsigned int mode;
-};
-
 extern int lapb_register(struct net_device *dev, struct lapb_register_struct *callbacks);
 extern int lapb_unregister(struct net_device *dev);
-extern int lapb_getparms(struct net_device *dev, struct lapb_parms_struct *parms);
-extern int lapb_setparms(struct net_device *dev, struct lapb_parms_struct *parms);
 extern int lapb_connect_request(struct net_device *dev);
 extern int lapb_disconnect_request(struct net_device *dev);
 extern int lapb_data_request(struct net_device *dev, struct sk_buff *skb);
net/lapb/lapb_iface.c renamed from net/lapb/lapb_iface.c.old +0 -67

79 lines not on this page · raw message

Documentation/networking/lapb-module.txt renamed from Documentation/networking/lapb-module.txt.old +0 -45

51 lines not on this page · raw message

#1 lore raw
Quoted 5 lines · Adrian Bunk

The patch below removes the following unused code:
- EXPORT_SYMBOL'ed functions lapb_getparms and lapb_setparms
- struct lapb_parms_struct

Please review whether it's correct or conflicts with pending changes.

Please keep these, they are used by out of kernel code and they are also required in order to run test sets on the full code functionality.