Skip to contentSkip to conversation

linux-2.6.9/fs/proc/proc_tty.c: avoid array

PATCH New [email protected] 1 participant 1 message Dec 25, 2004 Proc filesystem

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 2/2 linux-2.6.9/fs/proc/proc_tty.c: avoid array

Hi list,
no need for an array here. therefor no need to worry about possible overflows. seq_printf() can handle this.

avoid array in show_tty_range()

re,
walter

Signed-off-by walter harms <[email protected]>
Signed-off-by Domen Puncer <[email protected]>

---

 kj-domen/fs/proc/proc_tty.c |    4 +---
 1 files changed, 1 insertion(+), 3 deletions(-)
fs/proc/proc_tty.c renamed from fs/proc/proc_tty.c~remove_sprintf-fs_proc_proc_tty.c.bak +1 -3
diff -puN fs/proc/proc_tty.c~remove_sprintf-fs_proc_proc_tty.c.bak fs/proc/proc_tty.c
@@ -32,10 +32,8 @@ static void show_tty_range(struct seq_fi
 	seq_printf(m, "%-20s ", p->driver_name ? p->driver_name : "unknown");
 	seq_printf(m, "/dev/%-8s ", p->name);
 	if (p->num > 1) {
-		char	range[20];
-		sprintf(range, "%d-%d", MINOR(from),
+		seq_printf(m, "%3d %d-%d ", MAJOR(from), MINOR(from),
 			MINOR(from) + num - 1);
-		seq_printf(m, "%3d %7s ", MAJOR(from), range);
 	} else {
 		seq_printf(m, "%3d %7d ", MAJOR(from), MINOR(from));
 	}

diff -L fs/proc/proc_tty.c.bak -puN /dev/null /dev/null _