Skip to contentSkip to conversation

fix floppy build

PATCH In review Jeff Garzik 2 participants 2 messages Dec 29, 2004

Subsystems (2)
Block layer Floppy driver
lore
Share & tools
lore

Jeff Garzik

author
#0 lore raw

PATCH 1/1 fix floppy build

So my patch removing #include kernel/version.h broke the modular floppy build... doh. I would prefer to remove the redundancy of listing the kernel version each time the floppy driver is loaded.

See attached for 'bk pull' and example patch.

Please do a

bk pull bk://gkernel.bkbits.net/misc-2.6

This will update the following files:

 drivers/block/floppy.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

through these ChangeSets:

<[email protected]> (04/12/29 1.2079)
block/floppy.c: fix build by removing UTS_RELEASE use

It's redundant to the kernel message that prints out the kernel version, as well as many other places where one can request the kernel version.

drivers/block/floppy.c +1 -1
diff -Nru a/drivers/block/floppy.c b/drivers/block/floppy.c
@@ -4595,7 +4595,7 @@
 
 int init_module(void)
 {
-	printk(KERN_INFO "inserting floppy driver for " UTS_RELEASE "\n");
+	printk(KERN_INFO "inserting floppy driver\n");
 
 	if (floppy)
 		parse_floppy_cfg_string(floppy);
#1 lore raw
Quoted 27 lines · Jeff Garzik

So my patch removing #include kernel/version.h broke the modular floppy build... doh. I would prefer to remove the redundancy of listing the kernel version each time the floppy driver is loaded.

See attached for 'bk pull' and example patch.

Please do a

bk pull bk://gkernel.bkbits.net/misc-2.6

This will update the following files:

 drivers/block/floppy.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

through these ChangeSets:

<[email protected]> (04/12/29 1.2079)
block/floppy.c: fix build by removing UTS_RELEASE use

It's redundant to the kernel message that prints out the kernel version, as well as many other places where one can request the kernel version.

diff -Nru a/drivers/block/floppy.c b/drivers/block/floppy.c

drivers/block/floppy.c line 4598

Quoted 5 lines
drivers/block/floppy.c +1 -1
@@ -4595,7 +4595,7 @@
 
 int init_module(void)
 {
-	printk(KERN_INFO "inserting floppy driver for " UTS_RELEASE "\n");
+	printk(KERN_INFO "inserting floppy driver\n");

or just kill the printk completely..