Skip to contentSkip to conversation

remove bogus double softirq processing in cris

PATCH In review Christoph Hellwig 1 participant 2 messages Nov 14, 2004 – Jan 3, 2005

lore
Share & tools
lore

Christoph Hellwig

author
#0 lore raw

PATCH 1/1 remove bogus double softirq processing in cris

I sent this out long ago already, but it's still not in:

These days irq_exit does all softirq processing, so there's no need to call do_softirq again in cris.

Also is there any chance you could switch cris to use the new CONFIG_GENERIC_HARDIRQS code in 2.6.10-rc that would replace most of arch/cris/kernel/irq.c with generic code from kernel/irq/* ?

arch/cris/kernel/irq.c +0 -5
@@ -158,11 +158,6 @@ asmlinkage void do_IRQ(int irq, struct p
 		local_irq_disable();
         }
         irq_exit();
-
-	if (softirq_pending(cpu))
-                do_softirq();
-
-        /* unmasking and bottom half handling is done magically for us. */
 }
 
 /* this function links in a handler into the chain of handlers for the
author
#1 lore raw
Quoted 8 lines · Christoph Hellwig

I sent this out long ago already, but it's still not in:

These days irq_exit does all softirq processing, so there's no need to call do_softirq again in cris.

Also is there any chance you could switch cris to use the new CONFIG_GENERIC_HARDIRQS code in 2.6.10-rc that would replace most of arch/cris/kernel/irq.c with generic code from kernel/irq/* ?

ping? the broken code this patch removes really gets in the way of the softirq_pending() removal I plan to submit soon..

arch/cris/kernel/irq.c +0 -5
@@ -158,11 +158,6 @@ asmlinkage void do_IRQ(int irq, struct p
 		local_irq_disable();
         }
         irq_exit();
-
-	if (softirq_pending(cpu))
-                do_softirq();
-
-        /* unmasking and bottom half handling is done magically for us. */
 }
 
 /* this function links in a handler into the chain of handlers for the