Skip to contentSkip to conversation

ALSA Maestro driver spinlock bug.

DISCUSSION Dave Jones 2 participants 2 messages Jan 5, 2005

lore
Share & tools
lore

Dave Jones

author
#0 lore raw

One of our Fedora users reported a bug that showed up with spinlock debugging enabled.

sound/pci/es1968.c: es1968_measure_clock()

At line 1811, we acquire &chip->reg_lock
and then call snd_es1968_bob_inc(), which calls snd_es1968_bob_start(), which tries to acquire the same lock at line 885.

It barfs as a result. Is it safe to move
the snd_es1968_bob_inc() call before we
take the lock ?

Dave

#1 lore raw

At Tue, 4 Jan 2005 20:56:10 -0500,

Quoted 6 lines · Dave Jones

One of our Fedora users reported a bug that showed up with spinlock debugging enabled.

sound/pci/es1968.c: es1968_measure_clock()

Quoted 8 lines

At line 1811, we acquire &chip->reg_lock
and then call snd_es1968_bob_inc(), which calls snd_es1968_bob_start(), which tries to acquire the same lock at line 885.

It barfs as a result. Is it safe to move
the snd_es1968_bob_inc() call before we
take the lock ?

Already fixed in the recent ALSA version.

Takashi