ehci "hc died" on startup (chip bug workaround)
Subsystems (2)
PATCH 1/1 ehci "hc died" on startup (chip bug workaround)
We seem to have tracked some annoying board-coupled EHCI startup problems to a chip bug, with a simple workaround. Please merge.
- Dave
This fixes OSDL bugid #3056 for at least some users, where the EHCI driver gets a "fatal error" IRQ on startup ... only on certain boards, starting with the 2.6.6 or 2.6.7 kernels. These IRQs normally indicate that an invalid DMA address got passed to the controller, or something equally nasty and unrecoverable.
But it turns out that some of these controllers (at least ALI and Intel) are lying. They're issuing these IRQs without stopping, contrary to the EHCI spec ... so these IRQs can be recovered from. Thanks to Christian Iversen for noticing that his ALI controller would continue operating, which was the first real break in this annoying case.
This patch tests for these bogus IRQs, and ignores them ... working around what's clearly a chip bug. It's not clear why we started triggering that bug, but at least EHCI is now usable on boards exhibiting this problem.
drivers/usb/host/ehci-hcd.c +13 -7
@@ -903,14 +903,20 @@/* PCI errors [4.15.2.4] */ if (unlikely ((status &STS_FATAL ) !=0 )) { -ehci_err (ehci,"fatal error\n" ); +/* bogus "fatal" IRQs appear on some chips... why? */ + status =readl (&ehci->regs->status); +dbg_cmd (ehci,"fatal" ,readl (&ehci->regs->command)); +dbg_status (ehci,"fatal" , status); +if (status &STS_HALT ) { +ehci_err (ehci,"fatal error\n" ); dead: -ehci_reset (ehci); -writel (0 , &ehci->regs->configured_flag); -/* generic layer kills/unlinks all urbs, then -* uses ehci_stop to clean up the rest -*/ - bh =1 ; +ehci_reset (ehci); +writel (0 , &ehci->regs->configured_flag); +/* generic layer kills/unlinks all urbs, then +* uses ehci_stop to clean up the rest +*/ + bh =1 ; + } }if (bh)
Quoted 2 lines · David Brownell
We seem to have tracked some annoying board-coupled EHCI startup problems to a chip bug, with a simple workaround. Please merge.
Hm, I get a reject from this:drivers/usb/host/ehci-hcd.c 1.153: 1210 lines
patching file drivers/usb/host/ehci-hcd.c
Hunk #1 FAILED at 903.
1 out of 1 hunk FAILED -- saving rejects to file drivers/usb/host/ehci-hcd.c.rej
What kernel tree is it against?
thanks,
greg k-h
Quoted 8 lines · Greg KH
Quoted 2 lines · David Brownell
We seem to have tracked some annoying board-coupled EHCI startup problems to a chip bug, with a simple workaround. Please merge.
Hm, I get a reject from this:
...What kernel tree is it against?
Probably my gadget-2.6 tree; here's one that applies against current 2.5 BK or your USB integration tree. Sorry!
- Dave
This fixes OSDL bugid #3056 for at least some users, where the EHCI driver gets a "fatal error" IRQ on startup ... only on certain boards, starting with the 2.6.6 or 2.6.7 kernels. These IRQs normally indicate that an invalid DMA address got passed to the controller, or something equally nasty and unrecoverable.
But it turns out that some of these controllers (at least ALI and Intel) are lying. They're issuing these IRQs without stopping, contrary to the EHCI spec ... so these IRQs can be recovered from. Thanks to Christian Iversen for noticing that his ALI controller would continue operating, which was the first real break in this annoying case.
This patch tests for these bogus IRQs, and ignores them ... working around what's clearly a chip bug. It's not clear why we started triggering that bug, but at least EHCI is now usable on boards exhibiting this problem.
drivers/usb/host/ehci-hcd.c +13 -6
@@ -883,13 +903,20 @@/* PCI errors [4.15.2.4] */ if (unlikely ((status &STS_FATAL ) !=0 )) { -ehci_err (ehci,"fatal error\n" ); +/* bogus "fatal" IRQs appear on some chips... why? */ + status =readl (&ehci->regs->status); +dbg_cmd (ehci,"fatal" ,readl (&ehci->regs->command)); +dbg_status (ehci,"fatal" , status); +if (status &STS_HALT ) { +ehci_err (ehci,"fatal error\n" ); dead: -ehci_reset (ehci); -/* generic layer kills/unlinks all urbs, then -* uses ehci_stop to clean up the rest -*/ - bh =1 ; +ehci_reset (ehci); +writel (0 , &ehci->regs->configured_flag); +/* generic layer kills/unlinks all urbs, then +* uses ehci_stop to clean up the rest +*/ + bh =1 ; + } }if (bh)
Quoted 5 lines · David Brownell
Quoted 4 lines · Greg KH
Quoted 2 lines · David Brownell
We seem to have tracked some annoying board-coupled EHCI startup problems to a chip bug, with a simple workaround. Please merge.
Quoted 7 lines
Quoted 4 lines
Hm, I get a reject from this:
...What kernel tree is it against?
Probably my gadget-2.6 tree; here's one that applies against current 2.5 BK or your USB integration tree. Sorry!
Ah, much better, that worked. Thanks, applied.
greg k-h