Skip to contentSkip to conversation

drivers/mmc/wbsd.c

DISCUSSION Andrew Morton 2 participants 2 messages Jan 6, 2005 – Jan 10, 2005

lore
Share & tools
lore
#0 lore raw

static inline void wbsd_kunmap_sg(struct wbsd_host* host)

{
	kunmap_atomic(host->cur_sg->page, KM_BIO_SRC_IRQ);
}

Guys, kunmap_atomic() takes a kernel virtual address (the value which kmap_atomic() returned).

Passing it the address of a pageframe will have unpleasant results.

#1 lore raw
Quoted 11 lines · Andrew Morton

static inline void wbsd_kunmap_sg(struct wbsd_host* host)

{
	kunmap_atomic(host->cur_sg->page, KM_BIO_SRC_IRQ);
}

Guys, kunmap_atomic() takes a kernel virtual address (the value which kmap_atomic() returned).

Passing it the address of a pageframe will have unpleasant results.

Thanks. kunmap_atomic() just messes with the preemption stuff (on x86 at least) so it probably would have gone unnoticed for a while. I've fixed it now and it will be included in the next patch set.

Rgds
Pierre