Skip to contentSkip to conversation

sn/kernel/irq.o link failure in 2.6.10

PATCH dann frazier 2 participants 2 messages Jan 6, 2005

lore
Share & tools
lore
#0 lore raw

arch/ia64/sn/built-in.o(.text+0x1ee2): In function `sn_set_affinity_irq':
: undefined reference to `set_irq_affinity_info'

We probably need to wrap the set_irq_affinity_info in an #ifdef CONFIG_SMP - but should other code be ifdef'd out as well?

arch/ia64/sn/kernel/irq.c renamed from arch/ia64/sn/kernel/irq.c.orig +2 -0
@@ -183,7 +183,9 @@
 
 			sn_irq_info = sn_irq_info->irq_next;
 
+#ifdef CONFIG_SMP
 			set_irq_affinity_info((irq & 0xff), cpuphys, 0);
+#endif
 		} else {
 			break;	/* snp_affinity failed the intr_alloc */
 		}
#1 lore raw
Quoted 13 lines · dann frazier

arch/ia64/sn/built-in.o(.text+0x1ee2): In function `sn_set_affinity_irq':
: undefined reference to `set_irq_affinity_info'

We probably need to wrap the set_irq_affinity_info in an #ifdef CONFIG_SMP
- but should other code be ifdef'd out as well?

--- kernel-source-2.6.10/arch/ia64/sn/kernel/irq.c.orig 2005-01-06 12:40:30.170327564 -0700 +++ kernel-source-2.6.10/arch/ia64/sn/kernel/irq.c 2005-01-06 13:25:36.521856911 -0700 @@ -183,7 +183,9 @@

    sn_irq_info = sn_irq_info->irq_next;

arch/ia64/sn/kernel/irq.c line 191

Quoted 6 lines
arch/ia64/sn/kernel/irq.c renamed from arch/ia64/sn/kernel/irq.c.orig +2 -0
+#ifdef CONFIG_SMP
    set_irq_affinity_info((irq & 0xff), cpuphys, 0);
+#endif
   } else {
    break; /* snp_affinity failed the intr_alloc */
   }

I'd rather see a no-op version added under #else /* !CONFIG_SMP */ in arch/ia64/kernel/irq.c...

Jesse