Skip to contentSkip to conversation

2.6: fs/coda/dir.c: coda_hasmknod seems to be buggy

DISCUSSION Adrian Bunk 2 participants 2 messages Jan 6, 2005 – Jan 7, 2005

lore
Share & tools
lore
#0 lore raw

Function coda_mknod in fs/coda/dir.c (I checked 2.6.10-mm2) stats with:

<-- snip -->

...
static int coda_mknod(struct inode *dir, struct dentry *de, int mode, dev_t rdev)

{
        int error=0;
        const char *name=de->d_name.name;
        int length=de->d_name.len;
        struct inode *inode;
        struct CodaFid newfid;
        struct coda_vattr attrs;

        if ( coda_hasmknod == 0 )
                return -EIO;

<more code>
...

<-- snip -->

The problem is that not a single place in the kernel assigns any value to coda_hasmknod.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#1 lore raw
Quoted 1 line · Adrian Bunk

Function coda_mknod in fs/coda/dir.c (I checked 2.6.10-mm2) stats with:

Thanks,

Device nodes do not make much sense in a distributed filesystem. I never removed this code just in case anyone (i.e. not Coda) was using it, but you just proved that there can be no other user of this code.

I'll remove the has_mknod related parts.

Jan