net/e1000_osdep: replace schedule_timeout() with msleep()
Subsystems (3)
PATCH 6/28 net/e1000_osdep: replace schedule_timeout() with msleep()
Hi,
Description: Use msleep() instead of schedule_timeout() to guarantee the task delays as expected.
Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/net/e1000/e1000_osdep.h +1 -2
@@ -46,8 +46,7 @@/* Don't mdelay in interrupt context! */ \BUG (); \ }else { \ -set_current_state (TASK_UNINTERRUPTIBLE ); \ -schedule_timeout ((x *HZ )/1000 +2 ); \ +msleep (x); } }while (0 )/* Some workarounds require millisecond delays and are run during interrupt * context. Most notably, when establishing link, the phy may need tweaking
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 11 lines · Nishanth Aravamudan
Hi,
Description: Use
msleep()instead ofschedule_timeout()to guarantee the task delays as expected.Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/net/e1000/e1000_osdep.h line 52
Quoted 9 lines
drivers/net/e1000/e1000_osdep.h +1
-2@@ -46,8 +46,7 @@/* Don't mdelay in interrupt context! */ \BUG (); \ }else { \ -set_current_state (TASK_UNINTERRUPTIBLE ); \ -schedule_timeout ((x *HZ )/1000 +2 ); \ +msleep (x); } }while (0 )/* Some workarounds require millisecond delays and are run during interrupt * context. Most notably, when establishing link, the phy may need tweaking
Please ignore this patch, as there is already a more correct one in the 2.6.10-kj patchset. Sorry for the noise.
Thanks,
Nish
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors