Skip to contentSkip to conversation

net/act200l-sir: replace schedule_timeout()

PATCH Nishanth Aravamudan 1 participant 1 message Jan 7, 2005 Kernel janitors

lore
Share & tools
lore

Nishanth Aravamudan

author
#0 lore raw
Quoted 11 lines · Nishanth Aravamudan

Hi,

Description: Use msleep() instead of schedule_timeout() to guarantee the task delays as expected. There aren't any waitqueue events in the area, so I believe an absolute sleep should be ok.

Signed-off-by Nishanth Aravamudan <[email protected]>

drivers/net/irda/act200l-sir.c static int act200l_change_speed(struct s · line 183

Quoted 9 lines
drivers/net/irda/act200l-sir.c +1 -2
@@ -177,8 +177,7 @@ static int act200l_change_speed(struct s
 
 	/* Write control bytes */
 	sirdev_raw_write(dev, control, 3);
-	set_current_state(TASK_UNINTERRUPTIBLE);
-	schedule_timeout(msecs_to_jiffies(5));
+	msleep(5);
 
 	/* Go back to normal mode */
 	sirdev_set_dtr_rts(dev, TRUE, TRUE);

Please ignore this patch, as there is already a more correct one in the 2.6.10-kj patchset. Sorry for the noise.

Thanks,
Nish

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors