Skip to contentSkip to conversation

always enable regparm on i386

PATCH In review Adrian Bunk 2 participants 3 messages Jan 8, 2005 – Jan 9, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 always enable regparm on i386

The patch below always enables regparm on i386 (with gcc >= 3.0).

With this patch, it should get a better testing coverage in -mm.

If this doesn't cause any problems, I plan to send a patch to completely remove the CONFIG_REGPARM option after 2.6.11 will be released.

arch/i386/Kconfig renamed from arch/i386/Kconfig.old +2 -3
@@ -877,9 +877,8 @@
 	default y
 
 config REGPARM
-	bool "Use register arguments (EXPERIMENTAL)"
-	depends on EXPERIMENTAL
-	default n
+	bool
+	default y
 	help
 	Compile the kernel with -mregparm=3. This uses an different ABI
 	and passes the first three arguments of a function call in registers.
#1 lore raw
Quoted 7 lines · Adrian Bunk

The patch below always enables regparm on i386 (with gcc >= 3.0).

With this patch, it should get a better testing coverage in -mm.

If this doesn't cause any problems, I plan to send a patch to completely remove the CONFIG_REGPARM option after 2.6.11 will be released.

-mregparm has revealed at least two kernel bugs thus far. The ability to disable -mregparm is a useful diagnostic tool.

#2 lore raw
Quoted 11 lines · Andrew Morton
Quoted 7 lines · Adrian Bunk

The patch below always enables regparm on i386 (with gcc >= 3.0).

With this patch, it should get a better testing coverage in -mm.

If this doesn't cause any problems, I plan to send a patch to completely remove the CONFIG_REGPARM option after 2.6.11 will be released.

-mregparm has revealed at least two kernel bugs thus far. The ability to disable -mregparm is a useful diagnostic tool.

You are still able to disable it by editing the Kconfig file.

And even if the option will no longer be present at some time in the future, it will be trivial to disable it in the Makefile.

But currently (an option depending on EXPERIMENTAL) the testing coverage isn't that big, and with this -mm patch, most people using -mm [1] will have it enabled and notice if other problems pop up.

cu
Adrian

[1] except for those with gcc < 3.0 or !i386

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed