list_for_each_entry: fs-namespace.c

PATCH New [email protected] 1 participant 1 message Jan 10, 2005 VFS

lore

Share & tools

lore

[email protected]

author

2005-01-10 18:52 UTC #0 lore raw

PATCH 1/5 list_for_each_entry: fs-namespace.c

Make code more readable with list_for_each_entry.
Compile tested.

Signed-off-by Domen Puncer <[email protected]>

Signed-off-by Maximilian Attems <[email protected]>

Signed-off-by Domen Puncer <[email protected]>

---

 kj-domen/fs/namespace.c |    4 +---
 1 files changed, 1 insertion(+), 3 deletions(-)

fs/namespace.c renamed from fs/namespace.c~list-for-each-entry-fs_namespace +1 -3

diff -puN fs/namespace.c~list-for-each-entry-fs_namespace fs/namespace.c
@@ -536,7 +536,6 @@ lives_below_in_same_fs(struct dentry *d,
 static struct vfsmount *copy_tree(struct vfsmount *mnt, struct dentry *dentry)
 {
 	struct vfsmount *res, *p, *q, *r, *s;
-	struct list_head *h;
 	struct nameidata nd;
 
 	res = q = clone_mnt(mnt, dentry);

@@ -545,8 +544,7 @@ static struct vfsmount *copy_tree(struct
 	q->mnt_mountpoint = mnt->mnt_mountpoint;
 
 	p = mnt;
-	for (h = mnt->mnt_mounts.next; h != &mnt->mnt_mounts; h = h->next) {
-		r = list_entry(h, struct vfsmount, mnt_child);
+	list_for_each_entry(r, &mnt->mnt_mounts, mnt_child) {
 		if (!lives_below_in_same_fs(r->mnt_mountpoint, dentry))
 			continue;