Skip to contentSkip to conversation

video/pxafb: reorder add_wait_queue() and set_current_state()

PATCH In review [email protected] 1 participant 1 message Jan 10, 2005 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 video/pxafb: reorder add_wait_queue() and set_current_state()

Any comments would be, as always, appreciated.

-Nish

Description: Reorder set_current_state() and add_wait_queue(). There is a chance that a signal could be missed in between the two functions currently.

---

 kj-domen/drivers/video/pxafb.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/video/pxafb.c renamed from drivers/video/pxafb.c~reorder-state-drivers_video_pxafb +1 -1
diff -puN drivers/video/pxafb.c~reorder-state-drivers_video_pxafb drivers/video/pxafb.c
@@ -740,8 +740,8 @@ static void pxafb_disable_controller(str
 
 	DPRINTK("Disabling LCD controller\n");
 
-	add_wait_queue(&fbi->ctrlr_wait, &wait);
 	set_current_state(TASK_UNINTERRUPTIBLE);
+	add_wait_queue(&fbi->ctrlr_wait, &wait);
 
 	LCSR = 0xffffffff;	/* Clear LCD Status Register */
 	LCCR0 &= ~LCCR0_LDM;	/* Enable LCD Disable Done Interrupt */

_

-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt