Skip to contentSkip to conversation

gus_wave.c - vfree() checking cleanups

PATCH In review [email protected] 2 participants 3 messages Jan 10, 2005 – Jan 11, 2005 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 gus_wave.c - vfree() checking cleanups

gus_wave.c vfree() checking cleanups.

Signed-off by: James Lamanna <[email protected]>

---

 kj-domen/sound/oss/gus_wave.c |    3 +--
 1 files changed, 1 insertion(+), 2 deletions(-)
sound/oss/gus_wave.c renamed from sound/oss/gus_wave.c~vfree-sound_oss_gus_wave +1 -2
diff -puN sound/oss/gus_wave.c~vfree-sound_oss_gus_wave sound/oss/gus_wave.c
@@ -3126,8 +3126,7 @@ void __exit gus_wave_unload(struct addre
 	if (hw_config->slots[5] != -1)
 		sound_unload_mixerdev(hw_config->slots[5]);
 	
-	if(samples)
-		vfree(samples);
+	vfree(samples);
 	samples=NULL;
 }
 /* called in interrupt context */

_

-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

#1 lore raw

At Mon, 10 Jan 2005 19:36:35 +0100,

Quoted 2 lines · [email protected] wrote:

gus_wave.c vfree() checking cleanups.

I think Jaroslav isn't responsible for OSS stuff.
Could you repost it LKML rather than ALSA ML?

Takashi

-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

#2 lore raw
Quoted 7 lines · Takashi Iwai

At Mon, 10 Jan 2005 19:36:35 +0100,

Quoted 2 lines · [email protected] wrote:

gus_wave.c vfree() checking cleanups.

I think Jaroslav isn't responsible for OSS stuff.
Could you repost it LKML rather than ALSA ML?

In maintainers, he's listed under SOUND, and that deceived me. Will report to lkml later.

Thanks.

Quoted 3 lines

Takashi

-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt