scsi/ppa: replace schedule_timeout() with msleep()
PATCH 2/7 scsi/ppa: replace schedule_timeout() with msleep()
Any comments would be appreciated.
Description: Use msleep() instead of schedule_timeout() to guarantee the task delays as expected.
Signed-off-by Maximilian Attems <[email protected]>
Signed-off-by Domen Puncer <[email protected]>
---
kj-domen/drivers/scsi/ppa.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/ppa.c renamed from drivers/scsi/ppa.c~msleep-drivers_scsi_ppa +1 -1
@@ -1034,7 +1034,7 @@ static int __ppa_attach(struct parport * dev->waiting = &waiting;prepare_to_wait (&waiting, &wait,TASK_UNINTERRUPTIBLE );if (ppa_pb_claim (dev)) -schedule_timeout (3 *HZ ); +msleep (3000 );if (dev->wanted) {printk (KERN_ERR "ppa%d: failed to claim parport because " "a pardevice is owning the port for too long "
_
drivers/scsi/ppa.c static int __ppa_attach(struct parport * · line 1037
Quoted 2 lines · On Wed, 2005-01-12 at 00:22 +0100, [email protected] wrote:
drivers/scsi/ppa.c renamed from drivers/scsi/ppa.c~msleep-drivers_scsi_ppa +1
-1-schedule_timeout (3 *HZ ); +msleep (3000 );
This would make more sense as ssleep(3), wouldn't it?
James
Quoted 5 lines · James Bottomley
drivers/scsi/ppa.c static int __ppa_attach(struct parport * · line 1037
Quoted 2 lines · On Wed, 2005-01-12 at 00:22 +0100, [email protected] wrote:
drivers/scsi/ppa.c renamed from drivers/scsi/ppa.c~msleep-drivers_scsi_ppa +1
-1-schedule_timeout (3 *HZ ); +msleep (3000 );This would make more sense as ssleep(3), wouldn't it?
Actually, this patch should be dropped! :) msleep() will ignore any wait-queue events (triggered because of the prepare_to_wait() call). So please revert, if applied.
Thanks,
Nish