Skip to contentSkip to conversation

I2C: Fix bogus bitmask in lm63 debug message

PATCH New Jean Delvare 2 participants 2 messages May 19, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 I2C: Fix bogus bitmask in lm63 debug message

Hi Greg,

There is a bitmask error in one debug message of my lm63 chip driver. Nothing critical but still worth fixing, hence comes a patch.

Credits go to Mohan Mistry for finding the error.

Please apply,
thanks.

Signed-off-by Jean Delvare
drivers/i2c/chips/lm63.c renamed from drivers/i2c/chips/lm63.c.orig +2 -2
@@ -464,8 +464,8 @@
 		(data->config & 0x04) ? "tachometer input" :
 		"alert output");
 	dev_dbg(&client->dev, "PWM clock %s kHz, output frequency %u Hz\n",
-		(data->config_fan & 0x04) ? "1.4" : "360",
-		((data->config_fan & 0x04) ? 700 : 180000) / data->pwm1_freq);
+		(data->config_fan & 0x08) ? "1.4" : "360",
+		((data->config_fan & 0x08) ? 700 : 180000) / data->pwm1_freq);
 	dev_dbg(&client->dev, "PWM output active %s, %s mode\n",
 		(data->config_fan & 0x10) ? "low" : "high",
 		(data->config_fan & 0x20) ? "manual" : "auto");
Signature · 2 lines
Jean Delvare
http://khali.linux-fr.org/
Applied
#1 lore raw

PATCH 1/1 I2C: Fix bogus bitmask in lm63 debug message

Quoted 8 lines · Jean Delvare

Hi Greg,

There is a bitmask error in one debug message of my lm63 chip driver. Nothing critical but still worth fixing, hence comes a patch.

Credits go to Mohan Mistry for finding the error.

Please apply,

Applied, thanks.

greg k-h