x8664_ksyms.c: unexport register_die_notifier
PATCH 1/1 x8664_ksyms.c: unexport register_die_notifier
The only user of register_die_notifier (kernel/kprobes.c) can't be built modular. Therefore, it's the EXPORT_SYMBOL is superfluous.
arch/x86_64/kernel/x8664_ksyms.c renamed from arch/x86_64/kernel/x8664_ksyms.c.old +0 -1
@@ -198,7 +198,6 @@#endif EXPORT_SYMBOL (die_chain); -EXPORT_SYMBOL (register_die_notifier);#ifdef CONFIG_SMP EXPORT_SYMBOL (cpu_sibling_map);
Quoted 2 lines · Adrian Bunk
The only user of
register_die_notifier(kernel/kprobes.c) can't be built modular. Therefore, it's theEXPORT_SYMBOLis superfluous.
Please don't apply this, it was especially intended for modular debuggers. There is already a hacvked kdb around that uses it.
-Andi
Quoted 6 lines · Andi Kleen
Quoted 2 lines · Adrian Bunk
The only user of
register_die_notifier(kernel/kprobes.c) can't be built modular. Therefore, it's theEXPORT_SYMBOLis superfluous.Please don't apply this, it was especially intended for modular debuggers. There is already a hacvked kdb around that uses it.
eh didn't Tigran just mail lkml claiming that kdb and x86-64 really don't mix ??
Quoted 10 lines · Arjan van de Ven
Quoted 6 lines · Andi Kleen
Quoted 2 lines · Adrian Bunk
The only user of
register_die_notifier(kernel/kprobes.c) can't be built modular. Therefore, it's theEXPORT_SYMBOLis superfluous.Please don't apply this, it was especially intended for modular debuggers. There is already a hacvked kdb around that uses it.
eh didn't Tigran just mail lkml claiming that kdb and x86-64 really don't mix ??
No, I emailed saying that kdb on x86_64 does NOT show the values of parameters passed to functions in the backtrace. And, ok, it has some other bugs (e.g. reboot doesn't work on SMP) too. But generally speaking kdb does work on x86_64. It just still has bugs, but so does every piece of software. We should just fix them all, that's all :)
Kind regards
Tigran
Quoted 10 lines · Arjan van de Ven
Quoted 6 lines · Andi Kleen
Quoted 2 lines · Adrian Bunk
The only user of
register_die_notifier(kernel/kprobes.c) can't be built modular. Therefore, it's theEXPORT_SYMBOLis superfluous.Please don't apply this, it was especially intended for modular debuggers. There is already a hacvked kdb around that uses it.
eh didn't Tigran just mail lkml claiming that kdb and x86-64 really don't mix ??
It cannot display function arguments and uses imprecise backtrace right now (like normal oopses), other than that it works just fine.
-Andi
Quoted 6 lines · Andi Kleen
Quoted 5 lines · Arjan van de Ven
Quoted 4 lines · Andi Kleen
Quoted 2 lines · Adrian Bunk
The only user of
register_die_notifier(kernel/kprobes.c) can't be built modular. Therefore, it's theEXPORT_SYMBOLis superfluous.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Please don't apply this, it was especially intended for modular debuggers. There is already a hacvked kdb around that uses it.
eh didn't Tigran just mail lkml claiming that kdb and x86-64 really don't mix ??
It cannot display function arguments and uses imprecise backtrace right now (like normal oopses), other than that it works just fine.
does it need any other kernel patches? Because if it does it might as well patch this export in for it's specialist use
Quoted 10 lines · Arjan van de Ven
Quoted 9 lines · Andi Kleen
Quoted 8 lines · Arjan van de Ven
Quoted 6 lines · Andi Kleen
Quoted 2 lines · Adrian Bunk
The only user of
register_die_notifier(kernel/kprobes.c) can't be built modular. Therefore, it's theEXPORT_SYMBOLis superfluous.Please don't apply this, it was especially intended for modular debuggers. There is already a hacvked kdb around that uses it.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
eh didn't Tigran just mail lkml claiming that kdb and x86-64 really don't mix ??
It cannot display function arguments and uses imprecise backtrace right now (like normal oopses), other than that it works just fine.
does it need any other kernel patches? Because if it does it might as well patch this export in for it's specialist use
The modular kdb needs other patches right now yes, but I would still like to keep it for other debuggers. Previously we always had tons of ugly patchkit comming with every debugging add on and the exception notifiers were exactly designed to provide a clean interface for everybody for this. I definitely don't want to go back to the old "own patch for everbody" mess again on x86-64.
-Andi