Skip to contentSkip to conversation

fix CONFIG_AGP depencies

PATCH In review Christoph Hellwig 2 participants 3 messages Jan 16, 2005 Agpgart driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix CONFIG_AGP depencies

When I did an allmodconfig on ppc64 it selected agp although ppc64 doesn't support agp and has not agp.h so the build failed.

This patch makes CONFIG_AGP depend on the architectures that actually support agp.

drivers/char/agp/Kconfig +2 -1
@@ -1,5 +1,6 @@
 config AGP
-	tristate "/dev/agpgart (AGP Support)" if !GART_IOMMU && !M68K && !ARM
+	tristate "/dev/agpgart (AGP Support)" if !GART_IOMMU
+	depends on ALPHA || IA64 || PPC || X86
 	default y if GART_IOMMU
 	---help---
 	  AGP (Accelerated Graphics Port) is a bus system mainly used to
#1 lore raw
Quoted 10 lines · Christoph Hellwig

When I did an allmodconfig on ppc64 it selected agp although ppc64 doesn't support agp and has not agp.h so the build failed.

This patch makes CONFIG_AGP depend on the architectures that actually support agp.

drivers/char/agp/Kconfig line 6

Quoted 7 lines
drivers/char/agp/Kconfig +2 -1
@@ -1,5 +1,6 @@
 config AGP
-	tristate "/dev/agpgart (AGP Support)" if !GART_IOMMU && !M68K && !ARM
+	tristate "/dev/agpgart (AGP Support)" if !GART_IOMMU
+	depends on ALPHA || IA64 || PPC || X86
 	default y if GART_IOMMU
 	---help---
 	  AGP (Accelerated Graphics Port) is a bus system mainly used to

This doesn't seem to achieve what you want:
PPC is defined on ppc64...

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#2 lore raw
Quoted 2 lines · Adrian Bunk

This doesn't seem to achieve what you want:
PPC is defined on ppc64...

*grmbl*

drivers/char/agp/Kconfig +2 -1
@@ -1,5 +1,6 @@
 config AGP
-	tristate "/dev/agpgart (AGP Support)" if !GART_IOMMU && !M68K && !ARM
+	tristate "/dev/agpgart (AGP Support)" if !GART_IOMMU
+	depends on ALPHA || IA64 || PPC32 || X86
 	default y if GART_IOMMU
 	---help---
 	  AGP (Accelerated Graphics Port) is a bus system mainly used to